Skip to content

remains orphan resources with no machine refer to #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xrmzju opened this issue Nov 4, 2019 · 9 comments
Closed

remains orphan resources with no machine refer to #1718

xrmzju opened this issue Nov 4, 2019 · 9 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@xrmzju
Copy link
Member

xrmzju commented Nov 4, 2019

What steps did you take and what happened:
we intend to create 3 object in one replica reconcile process.if infraConfig and bootstrapConfig create success and machine create failed, then bootstrapConfig and infraConfig will be left there forever..

forgive me miss the delete part in L303, but i do see a lot of bootstrap remains in my env, i doubt the scale down action delete the machine only, but remains the gc controller to delete the infraconfig and bootstrapconfig, but if the machine has not been handled by machine controller, then no ownerRef would be set on infra config and bootstrap config, then the orphan object remains
What did you expect to happen:
scale a machineset with 10 replicas should means 10 infraConfigs,10 bootstrapConfigs and 10 machines, we only ensure 10 machines in our logic.

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 4, 2019
@xrmzju
Copy link
Member Author

xrmzju commented Nov 4, 2019

@detiber @ncdc @vincepri

@chuckha
Copy link
Contributor

chuckha commented Nov 4, 2019

/milestone v0.3.0
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 4, 2019
@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Nov 4, 2019
@xrmzju xrmzju changed the title remains orphan resources if create machine failed in machineset reconcile remains orphan resources with no machine refer to Nov 5, 2019
@vincepri
Copy link
Member

vincepri commented Nov 6, 2019

@xrmzju What version of Cluster API are you using?

@ncdc ncdc added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 6, 2019
@ncdc
Copy link
Contributor

ncdc commented Dec 6, 2019

@xrmzju is this still an issue for you?

@ncdc
Copy link
Contributor

ncdc commented Dec 20, 2019

Doing some milestone grooming. We can bring this back if we hear back.

/milestone Next

@vincepri
Copy link
Member

This is gonna be fixed in #1947

@vincepri
Copy link
Member

or at least part of it

@vincepri
Copy link
Member

Closing this for now, feel free to reopen if necessary

/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this issue.

In response to this:

Closing this for now, feel free to reopen if necessary

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

5 participants