Machines conditions should provide more visibility to the underlying Node

[vincepri]

Today, it's hard to understand that a Machine is fully healthy, and what determines a Machine not healthy.

For example, KCP performs kubeadm-specific health checks (inspect the etcd node, static pods, and so on). We should expose all of these internal checks by writing specific conditions on Machines from different controllers.

Let's brainstorm though on a design that could work across the board, given that kubeadm isn't the one and only bootstrapper used out there.

• Machine controller should try to verify as much as possible, and only manage conditions that are common across bootstrappers. For example, "NodeReady" is something that we can easily check.
• A new controller under KCP could check all control-plane nodes managed by KCP and start adding conditions that are very specific to how KCP deploys control plane nodes (stacked etcd, and so on).
• CABPK controller could be responsible for all generic kubeadm-specific machine information (TBD what that would look like though).

There is a clear overlap in these examples, in the final form they shouldn't have any. Each condition needs a clear owner/manager. The main goal of this issue is to provide a uniform and coherent in-depth view on a Machine's health.

/kind feature

[vincepri]

cc @detiber @fabriziopandini

[fabriziopandini]

rif #3139 (review)

[vincepri]

/milestone v0.3.x

[vincepri]

/milestone v0.4.0

[vincepri]

/priority important-soon

[sedefsavas]

We have some conditions to add to Machines and KCP to increase visibility, feedbacks welcome here:
https://docs.google.com/document/d/1pEMf8AuPgUF_ClTM4uCEiDkb-iyUgwcxinwArtpa45c/edit?usp=sharing

[fabriziopandini]

/assign
/lifecycle active

/milestone v0.3.11

[fabriziopandini]

#3900 is merged
/close

[k8s-ci-robot]

@fabriziopandini: Closing this issue.

In response to this:

#3900 is merged
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.