Consider using remote.NodeProviderIDIndex in MachinePool controller

[killianmuldoon]

The MachinePool controller currently looks for specific node references by first looping through all of the nodes in the cluster and then checking to see if the ProviderID is among those listed on the MachinePool object.
This could be made more efficient by using the remote.NodeProviderIDIndex which is how the Machine controller currently looks up nodes by provider ID.

Doing this would require refactoring the code in the MachinePool controller's getNodeReferences:

cluster-api/exp/internal/controllers/machinepool_controller_noderef.go

Line 155 in 051b006

func (r *MachinePoolReconciler) getNodeReferences(ctx context.Context, c client.Client, providerIDList []string) (getNodeReferencesResult, error) {

To look more like the Machine controller implementation and use index.NodeProviderIDField

cluster-api/internal/controllers/machine/machine_controller_noderef.go

Line 196 in f62294e

func (r *Reconciler) getNode(ctx context.Context, c client.Reader, providerID string) (*corev1.Node, error) {

/help-wanted
/area machinepool

[killianmuldoon]

/help wanted

[fabriziopandini]

/triage accepted
cc @Jont828 since he is working on MachinePools

[Jont828]

That seems reasonable. I'll take a look once I'm wrapped up with the DockerMachinePool Machines implementation.

[fabriziopandini]

/kind cleanup
/priority important-longterm

[cahillsf]

opened a PR for this, per @sbueringer closing this as "won't do"

#11071 (comment)

/close

[k8s-ci-robot]

@cahillsf: Closing this issue.

In response to this:

opened a PR for this, per @sbueringer closing this as "won't do"

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

Thx for working on this! Sorry should have realized this earlier :)

[cahillsf]

Thx for working on this! Sorry should have realized this earlier :)

np 👍