-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Add triage-party for the Cluster API backlog #10437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 4 commits into
kubernetes-sigs:main
from
fabriziopandini:triage-party
May 7, 2024
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| triage-party.tmp/ | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| .cache/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,269 @@ | ||
| settings: | ||
| name: cluster-api | ||
| min_similarity: 0.8 | ||
| repos: | ||
| - https://github.com/kubernetes-sigs/cluster-api | ||
| members: | ||
| - chrischdi | ||
| - enxebre | ||
| - fabriziopandini | ||
| - killianmuldoon | ||
| - sbueringer | ||
| - vincepri | ||
|
|
||
| collections: | ||
| - id: initial-triage | ||
| name: Initial Triage | ||
| dedup: false | ||
| description: > | ||
| Check new issue and apply labels for kind, priority, area (optional). | ||
| rules: | ||
| - triage-needs-kind | ||
| - triage-needs-priority | ||
|
|
||
| - id: triage-refinement | ||
| name: Triage Refinement | ||
| dedup: false | ||
| description: > | ||
| Work on issue to get them to an actionable state. | ||
| When ready, apply triage/accepted and help of good-first issue label | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| rules: | ||
| - triage-stale-awaiting-more-evidence | ||
| - triage-stale-kind-support | ||
| - triage-updated | ||
| - triage-again | ||
| - triage-lifecycle-stale-or-rotten-priority-critical-urgent | ||
| - triage-lifecycle-stale-or-rotten-priority-important-soon | ||
| - triage-lifecycle-stale-or-rotten-priority-important-longterm | ||
| - triage-lifecycle-frozen | ||
| - triage-all | ||
|
|
||
| - id: actionable | ||
| name: Actionable | ||
| description: > | ||
| Issue to be worked. | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| dedup: false | ||
| rules: | ||
| - actionable-not-assigned-without-help-or-good-first-issue | ||
| - actionable-updated | ||
| - actionable-all | ||
|
|
||
| - id: fix-me | ||
| name: Fix-me! | ||
| description: > | ||
| Ensure we are using the labels in a consistent way. | ||
| dedup: false | ||
| rules: | ||
| - fixme-avoid-triage-needs-information | ||
| - fixme-avoid-kind-design | ||
| - fixme-kind-proposal-without-kind-feature | ||
| - fixme-kind-support-with-other-kinds | ||
| - fixme-triage-accepted-with-kind-support-or-priority-awaiting-more-evidence | ||
| - fixme-help-or-good-first-issue-before-triage-accepted | ||
| - fixme-lifecycle-frozen-with-priority-critical-urgent-priority-important-soon-priority-important-longterm | ||
|
|
||
| rules: | ||
| # Phase: Initial triage | ||
|
|
||
| triage-needs-kind: | ||
| # WHY?: kinds need to be assigned by maintainers, let's do it! | ||
| name: "needs-kind" | ||
| resolution: "Add a kind/ label: api-change, bug, cleanup, deprecation, design, documentation, failing-test, feature, flake, proposal, regression, release-blocking, support" | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| type: issue | ||
| filters: | ||
| # TODO: Configure plugins so needs-kind label is applied + use it for this filter | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - label: "!kind/.*" | ||
|
|
||
| triage-needs-priority: | ||
| # WHY?: kinds need to be assigned by maintainers, let's do it! | ||
| name: "needs-priority" | ||
| resolution: "Add a priority/ label: priority/critical-urgent > priority/important-soon > priority/important-longterm > priority/backlog > priority/awaiting-more-evidence" | ||
| type: issue | ||
| filters: | ||
| # TODO: Configure plugins so needs-priority label is applied + use it for this filter | ||
| - label: "!priority/.*" | ||
|
|
||
| # Phase: Triage finalization | ||
|
|
||
| triage-stale-awaiting-more-evidence: | ||
| # WHY?: issue authors are supposed to provide answers timely when an issue is labeled priority/awaiting-more-evidence, otherwise /close | ||
| name: "priority/awaiting-more-evidence not commented in the last 15 days" | ||
| resolution: "Consider if to close with /close, consider if to remove priority/awaiting-more-evidence label" | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| type: issue | ||
| filters: | ||
| - label: "!triage/accepted" | ||
| - label: "priority/awaiting-more-evidence" | ||
| - commented: +15d | ||
|
|
||
| triage-stale-kind-support: | ||
| # WHY?: support request are supposed to be quick back and forth between authors and maintainers, otherwise /close | ||
| name: "Support request not commented in the last 15 days" | ||
| resolution: "Consider if to close with /close, consider if to change kind" | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| type: issue | ||
| filters: | ||
| - label: "!triage/accepted" | ||
| - label: "kind/support" | ||
| - commented: +15d | ||
|
|
||
| triage-updated: | ||
| # WHY?: maintainers are supposed to keep up with issue discussions and help to move to actionable | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| name: "Issues with updates in the last month" | ||
| resolution: "Check if the issue is now actionable by applying /triage accepted, help in making progress, consider if to change priority or kind" | ||
| type: issue | ||
| filters: | ||
| - label: "!triage/accepted" | ||
| - commented: -30d | ||
| - tag: "!member-last" | ||
|
|
||
| triage-again: | ||
| # WHY?: maintainers are supposed to re-assess triaged issues after some time (frequency depends on priority) | ||
| # Note: this is a clear sign of project lacking contributors. At some point - might be after two back and forth -, we should give up and close. | ||
| name: "Issues back to triage" | ||
| resolution: "Confirm that this issue is still relevant with /triage accepted, close this issue with /close" | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| type: issue | ||
| filters: | ||
| - label: "!triage/accepted" | ||
| - un-triaged: +0d | ||
|
|
||
| triage-lifecycle-stale-or-rotten-priority-critical-urgent: | ||
| # WHY?: issue with priority/critical-urgent do not get automatically closed, it is up to maintainers to take a look again | ||
| # Note: this is a clear sign of project lacking contributors. At some point - might be after two back and forth -, we should give up and close. | ||
| name: "Issue with priority/critical-urgent, lifecycle/stale or rotten, and not commented in the last month" | ||
| resolution: "Consider if bring this issue to the attention of the community, consider if to change priority with /priority important-soon, /priority important-longterm or /priority backlog, consider if to close with /close" | ||
| type: issue | ||
| filters: | ||
| - label: "!triage/accepted" | ||
| - label: "priority/critical-urgent" | ||
| - label: "lifecycle/(stale|rotten)" | ||
| - commented: +30d | ||
|
|
||
| triage-lifecycle-stale-or-rotten-priority-important-soon: | ||
| # WHY?: issue with priority/important-soon do not get automatically closed, it is up to maintainers to take a look again | ||
| # Note: this is a clear sign of project lacking contributors. At some point - might be after two back and forth -, we should give up and close. | ||
| name: "Issue with priority/important-soon, lifecycle/stale or rotten, not commented in the last 2 month" | ||
| resolution: "Consider if to change priority with /priority important-longterm or /priority backlog, consider if to close with /close" | ||
| type: issue | ||
| filters: | ||
| - label: "!triage/accepted" | ||
| - label: "priority/important-soon" | ||
| - label: "lifecycle/(stale|rotten)" | ||
| - commented: +60d | ||
|
|
||
| triage-lifecycle-stale-or-rotten-priority-important-longterm: | ||
| # WHY?: issue with priority/important-longterm do not get automatically closed, it is up to maintainers to take a look again | ||
| # Note: this is a clear sign of project lacking contributors. At some point - might be after two back and forth -, we should give up and close. | ||
| name: "Issue with priority/important-longterm, lifecycle/stale or rotten, not commented in the last 6 months" | ||
| resolution: "Consider if to change priority with /priority backlog, consider if to clos with /closee" | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| type: issue | ||
| filters: | ||
| - label: "!triage/accepted" | ||
| - label: "priority/important-longterm" | ||
| - label: "lifecycle/(stale|rotten)" | ||
| - commented: +180d | ||
|
|
||
| triage-lifecycle-frozen: | ||
| # WHY?: issue with lifecycle/frozen do not get automatically closed, it is up to maintainers to take a look again | ||
| # Note: this is a clear sign of project lacking contributors. At some point - might be after two back and forth -, we should give up and close. | ||
| name: "Issue with lifecycle/frozen, not commented in the last 6 months" | ||
| resolution: "Consider if to close with /close" | ||
| type: issue | ||
| filters: | ||
| - label: "!triage/accepted" | ||
| - label: "lifecycle/frozen" | ||
| - commented: +180d | ||
|
|
||
| triage-all: | ||
| name: "All the issue in triage" | ||
| resolution: "Check if the issue is now actionable by applying /triage accepted, help in making progress, consider if to change priority or kind" | ||
| type: issue | ||
| filters: | ||
| - label: "!triage/accepted" | ||
|
|
||
| # Phase: Actionable | ||
|
|
||
| actionable-not-assigned-without-help-or-good-first-issue: | ||
| # WHY?: issue actionable must be assigned to someone or seeking for help | ||
| name: "Issues not assigned without help or good-first-issue" | ||
| resolution: "Apply /help or /good-first-issue" | ||
| type: issue | ||
| filters: | ||
| - label: "triage/accepted" | ||
| - label: "!(help|good-first-issue)" | ||
| - tag: "!assigned" | ||
|
|
||
| actionable-updated: | ||
| # WHY?: maintainers are supposed to keep up with issue discussions | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| name: "Issues with updates in the last month" | ||
| resolution: "Check updates" | ||
| type: issue | ||
| filters: | ||
| - label: "triage/accepted" | ||
| - commented: -30d | ||
| - tag: "!member-last" | ||
|
|
||
| actionable-all: | ||
| name: "All the actionable issues" | ||
| type: issue | ||
| filters: | ||
| - label: "triage/accepted" | ||
|
|
||
| # Fix-me | ||
| # WHY?: Let's try to be diligent in using labels | ||
|
|
||
| fixme-avoid-triage-needs-information: | ||
| name: "With triage/needs-information (let's not use this label)" | ||
| resolution: "Remove triage/needs-information, se priority/awaiting-more-evidence instead" | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| type: issue | ||
| filters: | ||
| - label: "triage/needs-information" | ||
|
|
||
| fixme-avoid-kind-design: | ||
| name: "With kind/design (let's not use this label)" | ||
| resolution: "remove kind/design, use kind/proposal instead" | ||
| type: issue | ||
| filters: | ||
| - label: "kind/design" | ||
|
|
||
| fixme-kind-proposal-without-kind-feature: | ||
| name: "With kind/proposal without kind/feature" | ||
| resolution: "Add kind/feature (we usually write proposals for new features, so kind/proposal and kind/feature should go together)" | ||
| type: issue | ||
| filters: | ||
| - label: "kind/proposal" | ||
| - label: "!kind/feature" | ||
|
|
||
| fixme-kind-support-with-other-kinds: | ||
| name: "With kind/support and also other kinds" | ||
| resolution: "Remove incorrect kinds (kind/support should not be combined with other kinds)" | ||
| type: issue | ||
| filters: | ||
| - label: "kind/support" | ||
| - label: "kind/(feature|documentation|bug|flake|cleanup|design|proposal|deprecation|regression|api-change|failing-test|release-blocking)" | ||
|
|
||
| fixme-triage-accepted-with-kind-support-or-priority-awaiting-more-evidence: | ||
| name: "With triage/accepted and kind/support or priority/awaiting-more-evidence" | ||
| resolution: "Remove triage/accepted (triage/accepted should not be applied to issue with kind/support or priority/awaiting-more-evidence)" | ||
| type: issue | ||
| filters: | ||
| - label: "triage/accepted" | ||
| - label: "(kind/support|priority/awaiting-more-evidence)" | ||
|
|
||
| fixme-help-or-good-first-issue-before-triage-accepted: | ||
| name: "With help or good-first-issue applied before triage/accepted" | ||
| resolution: "help or good-first-issue should not be applied before triage/accepted" | ||
| type: issue | ||
| filters: | ||
| - label: "(help|good-first-issue)" | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - label: "!triage/accepted" | ||
| - tag: "!untriaged" | ||
|
|
||
| fixme-lifecycle-frozen-with-priority-critical-urgent-priority-important-soon-priority-important-longterm: | ||
| name: "With lifecycle/frozen and one of priority/critical-urgent, priority/important-soon or priority/important-longterm" | ||
| resolution: "Remove triage/accepted (priority/critical-urgent, priority/important-soon or priority/important-longterm are not subject to lifecycle events)" | ||
fabriziopandini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| type: issue | ||
| filters: | ||
| - label: "lifecycle/frozen" | ||
| - label: "priority/(critical-urgent|important-soon|important-longterm)" | ||
|
|
||
| # TODO: add more checks about invalid combinations of labels | ||
| # - ... | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.