Add owner reference for machines created via machineset controller #108
Conversation
k8s-ci-robot
added
size/L
|
Hi @k4leung4. Thanks for your PR. I'm waiting for a kubernetes or kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
|
/assign @jessicaochen @krousey @mvladev |
|
|
||
| // Machine owned by another controller. | ||
| if metav1.GetControllerOf(machine) != nil && !metav1.IsControlledBy(machine, machineSet) { | ||
| glog.V(2).Infof("Skipping machine (%v), as it is owned by someone else.", machine.Name) |
There was a problem hiding this comment.
(nit)
Should be warning or error level as this is a problem situation that requires fixing.
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k4leung4, krousey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The pull is for machine/machineset owner refs
The pull is for machine/machineset owner refs
build outside of goreleaser
What this PR does / why we need it:
This adds owner reference to machine objects created through the machineset controller. This allows garbage collection and cascading deletion to work.
Deleting the machineset will trigger the corresponding machines to be deleted.
Continuation from kubernetes-retired/kube-deploy#667
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #41
Special notes for your reviewer:
Release note:
@kubernetes/kube-deploy-reviewers