✨ Add e2e tests & clusterctl changes for cross-ns CC ref #11395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XL
Danil-Grigorev
force-pushed
the
standardize-references-full
branch
5 times, most recently
from
d92a5c2 to
7560e66
Compare
Danil-Grigorev
changed the title
Danil-Grigorev
changed the title
k8s-ci-robot
added
needs-rebase
Danil-Grigorev
force-pushed
the
standardize-references-full
branch
from
7560e66 to
09ce978
Compare
k8s-ci-robot
added
size/L
fabriziopandini
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Renamed wip since it builds on a PR not yet merged |
test/e2e/data/infrastructure-docker/main/cluster-template-cross-ns-topology/cluster.yaml
Outdated
Show resolved
Hide resolved
Danil-Grigorev
force-pushed
the
standardize-references-full
branch
from
09ce978 to
2d4a64e
Compare
k8s-ci-robot
added
size/XL
Danil-Grigorev
force-pushed
the
standardize-references-full
branch
from
2d4a64e to
c181e3e
Compare
k8s-ci-robot
removed
the
size/XL
|
cc @Danil-Grigorev the above comments should help to get this one green :-) |
Danil-Grigorev
force-pushed
the
standardize-references-full
branch
2 times, most recently
from
5d11aa7 to
0c1c5b9
Compare
|
/test pull-cluster-api-e2e-main |
|
Nice, only another test failed. I call this a win! :) /test pull-cluster-api-e2e-main |
|
/test pull-cluster-api-e2e-main |
2 similar comments
|
/test pull-cluster-api-e2e-main |
|
/test pull-cluster-api-e2e-main |
sbueringer
added
tide/merge-method-squash
Danil-Grigorev
force-pushed
the
standardize-references-full
branch
2 times, most recently
from
5902f12 to
460dc51
Compare
sbueringer
reviewed
Feb 4, 2025
- Prevent duplicate CC creation in template processing - Test runtimextension integration - Add changes to CC rebase e2e test - Add a note CLUSTER_CLASS_NAMESPACE to the clusterctl contract Co-authored-by: Christian Schlotter <[email protected]> Co-authored-by: Stefan Büringer <[email protected]> Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
standardize-references-full
branch
from
460dc51 to
b801b94
Compare
|
Thank you very much!! /approve Leving lgtm to @chrischdi 🙏 🤞 🍀 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 43af4e7d1255168333ec1d7530ca7314071b3ef1
|
|
Alrighty. I'll keep track of the cherry-pick for this PR. Now onwards to the final PR #11649 so we can cherry-pick all of this :) |
|
/cherry-pick release-1.9 |
|
@sbueringer: new pull request created: #11845 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows
clusterctlto create a template with a reference to CC located in a different namespace.This change allows to perform e2e tests in a multi-ns environment.
Added e2e tests to verify cluster-class quick-start scenario and runtime extension scenario in a cross-namespaced context.
The PR is built on top of:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5673