-
Notifications
You must be signed in to change notification settings - Fork 1.4k
⚠️ Deprecate replica counters planned for removal #11516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Deprecate replica counters planned for removal #11516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
LGTM label has been added. Git tree hash: 27e41e60cdd47f9613c4d0fd6ef74d19a843c5b2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for your conveinience |
/hold cancel /cherry-pick release-1.9 |
@chrischdi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@chrischdi: new pull request created: #11517 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20240916-improve-status-in-CAPI-resources.md introduced the idea of having consistent replica fields across all API objects.
This PR adds an early deprecation notice for replica fields that will be dropped when implementing this proposal, so API users can start planning for when this will happen (similar to what we already did for FailureMessage and FailureReason)
/area api