Skip to content

🌱 Add clusterctl describe to E2E artifacts #11966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

🌱 Add clusterctl describe to E2E artifacts #11966

merged 2 commits into from
Mar 14, 2025

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Fixes #11954

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 12, 2025
@fabriziopandini
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main

/test pull-cluster-api-e2e-blocking-main

/test pull-cluster-api-e2e-conformance-ci-latest-main

/test pull-cluster-api-e2e-conformance-main

/test pull-cluster-api-e2e-latestk8s-main

/test pull-cluster-api-e2e-main

/test pull-cluster-api-e2e-mink8s-main

/test pull-cluster-api-e2e-upgrade-1-32-1-33-main

/test pull-cluster-api-test-main

/test pull-cluster-api-test-mink8s-main

/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main

pull-cluster-api-build-main

pull-cluster-api-e2e-blocking-main

pull-cluster-api-test-main

pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main

tobiasgiese
tobiasgiese reviewed Mar 13, 2025
View reviewed changes
test/framework/spec_helpers.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it makes sense to split the change into two commits (i.e., func move and the e2e change)?

@fabriziopandini fabriziopandini force-pushed the add-clusterctl-describe-to-E2E branch from bcdfb6f to dc52c20 Compare March 13, 2025 09:20
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main

sbueringer
sbueringer reviewed Mar 13, 2025
View reviewed changes
test/framework/spec_helpers.go Outdated
for _, c := range clusters.Items {
DescribeCluster(ctx, DescribeClusterInput{
ClusterctlConfigPath: input.ClusterctlConfigPath,
LogFolder: filepath.Join(input.ArtifactFolder, "clusters", c.Name),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put this file somewhere below

https://gcsweb.k8s.io/gcs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api/11966/pull-cluster-api-e2e-blocking-main/1900114995866243072/artifacts/clusters/bootstrap

e.g. here: https://gcsweb.k8s.io/gcs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api/11966/pull-cluster-api-e2e-blocking-main/1900114995866243072/artifacts/clusters/bootstrap/resources/quick-start-g2ekd7/Cluster/

The current location https://gcsweb.k8s.io/gcs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api/11966/pull-cluster-api-e2e-blocking-main/1900114995866243072/artifacts/clusters/quick-start-km06hh/
is usually for resources from the workload cluster

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main
/hold to squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member

Thank you very much!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6c90221081f2722620d8ce4b673477364b7978c9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@fabriziopandini fabriziopandini force-pushed the add-clusterctl-describe-to-E2E branch from 4097ec1 to 143f280 Compare March 14, 2025 17:23
@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1c97cbe into kubernetes-sigs:main Mar 14, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Mar 14, 2025
@fabriziopandini fabriziopandini deleted the add-clusterctl-describe-to-E2E branch April 12, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@tobiasgiese tobiasgiese tobiasgiese left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

Add output of clusterctl describe cluster to test artifacts
4 participants
@fabriziopandini @k8s-ci-robot @sbueringer @tobiasgiese