Skip to content

🌱 Add v1beta2 conditions to IPAddressClaim #11971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions config/crd/bases/ipam.cluster.x-k8s.io_ipaddressclaims.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions exp/ipam/api/v1alpha1/conversion.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (

clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
ipamv1 "sigs.k8s.io/cluster-api/exp/ipam/api/v1beta1"
utilconversion "sigs.k8s.io/cluster-api/util/conversion"
)

func (src *IPAddress) ConvertTo(dstRaw conversion.Hub) error {
Expand Down Expand Up @@ -67,6 +68,14 @@ func (src *IPAddressClaim) ConvertTo(dstRaw conversion.Hub) error {
}
}

// Manually restore data.
restored := &ipamv1.IPAddressClaim{}
if ok, err := utilconversion.UnmarshalData(src, restored); err != nil || !ok {
return err
}

dst.Status.V1Beta2 = restored.Status.V1Beta2

return nil
}

Expand All @@ -90,6 +99,11 @@ func (dst *IPAddressClaim) ConvertFrom(srcRaw conversion.Hub) error {
dst.ObjectMeta.Labels[clusterv1.ClusterNameLabel] = src.Spec.ClusterName
}

// Preserve Hub data on down-conversion except for metadata
if err := utilconversion.MarshalData(src, dst); err != nil {
return err
}

return nil
}

Expand All @@ -108,3 +122,7 @@ func (dst *IPAddressClaimList) ConvertFrom(srcRaw conversion.Hub) error {
func Convert_v1beta1_IPAddressClaimSpec_To_v1alpha1_IPAddressClaimSpec(from *ipamv1.IPAddressClaimSpec, to *IPAddressClaimSpec, scope apiconversion.Scope) error {
return autoConvert_v1beta1_IPAddressClaimSpec_To_v1alpha1_IPAddressClaimSpec(from, to, scope)
}

func Convert_v1beta1_IPAddressClaimStatus_To_v1alpha1_IPAddressClaimStatus(from *ipamv1.IPAddressClaimStatus, to *IPAddressClaimStatus, scope apiconversion.Scope) error {
return autoConvert_v1beta1_IPAddressClaimStatus_To_v1alpha1_IPAddressClaimStatus(from, to, scope)
}
16 changes: 6 additions & 10 deletions exp/ipam/api/v1alpha1/zz_generated.conversion.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 31 additions & 0 deletions exp/ipam/api/v1beta1/ipaddressclaim_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,21 @@ type IPAddressClaimStatus struct {
// conditions summarises the current state of the IPAddressClaim
// +optional
Conditions clusterv1.Conditions `json:"conditions,omitempty"`

// v1beta2 groups all the fields that will be added or modified in IPAddressClaim's status with the V1Beta2 version.
// +optional
V1Beta2 *IPAddressClaimV1Beta2Status `json:"v1beta2,omitempty"`
}

// IPAddressClaimV1Beta2Status groups all the fields that will be added or modified in IPAddressClaimStatus with the V1Beta2 version.
// See https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20240916-improve-status-in-CAPI-resources.md for more context.
type IPAddressClaimV1Beta2Status struct {
// conditions represents the observations of a IPAddressClaim's current state.
// +optional
// +listType=map
// +listMapKey=type
// +kubebuilder:validation:MaxItems=32
Conditions []metav1.Condition `json:"conditions,omitempty"`
}

// +kubebuilder:object:root=true
Expand Down Expand Up @@ -81,6 +96,22 @@ func (m *IPAddressClaim) SetConditions(conditions clusterv1.Conditions) {
m.Status.Conditions = conditions
}

// GetV1Beta2Conditions returns the set of conditions for this object.
func (m *IPAddressClaim) GetV1Beta2Conditions() []metav1.Condition {
if m.Status.V1Beta2 == nil {
return nil
}
return m.Status.V1Beta2.Conditions
}

// SetV1Beta2Conditions sets conditions for an API object.
func (m *IPAddressClaim) SetV1Beta2Conditions(conditions []metav1.Condition) {
if m.Status.V1Beta2 == nil {
m.Status.V1Beta2 = &IPAddressClaimV1Beta2Status{}
}
m.Status.V1Beta2.Conditions = conditions
}

// +kubebuilder:object:root=true

// IPAddressClaimList is a list of IPAddressClaims.
Expand Down
28 changes: 28 additions & 0 deletions exp/ipam/api/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.