Skip to content

[release-1.10] 🐛 Make joinConfiguration.discovery.bootstrapToken.token optional #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

Amulyam24
Copy link
Contributor

@Amulyam24 Amulyam24 commented Apr 29, 2025

What this PR does / why we need it:
cheery-pick of #12107

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

🐛 Make joinConfiguration.discovery.bootstrapToken.token optional
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Apr 29, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2025
@Amulyam24
Copy link
Contributor Author

/cc @Karthik-K-N @fabriziopandini

@mboersma
Copy link
Contributor

/retitle [release-1.10] 🐛 Make joinConfiguration.discovery.bootstrapToken.token optional

@k8s-ci-robot k8s-ci-robot changed the title 🐛 Make joinConfiguration.discovery.bootstrapToken.token optional [release-1.10] 🐛 Make joinConfiguration.discovery.bootstrapToken.token optional Apr 29, 2025
@mboersma mboersma mentioned this pull request Apr 29, 2025
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7c7f8d9109cd6c8518853e7adaa6795404a865ac

@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@fabriziopandini
Copy link
Member

/area bootstrap

@k8s-ci-robot k8s-ci-robot added area/bootstrap Issues or PRs related to bootstrap providers and removed do-not-merge/needs-area PR is missing an area label labels Apr 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 647a1b7 into kubernetes-sigs:release-1.10 Apr 29, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bootstrap Issues or PRs related to bootstrap providers cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants