Skip to content

🐛 [release-1.10] Relax minLength for bootstrap.dataSecretName to 0 #12180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

damdo
Copy link
Member

@damdo damdo commented May 9, 2025

What this PR does / why we need it:

Manual backport of #12164

Changes the validation for Machine spec's bootstrap.dataSecretName to // +kubebuilder:validation:MinLength=0. This allows an empty string, which is an existing use case for managed MachinePools.

Which issue(s) this PR fixes:

Fixes #12161

/area bootstrap

@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone May 9, 2025
@k8s-ci-robot k8s-ci-robot added area/bootstrap Issues or PRs related to bootstrap providers cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2025
@damdo
Copy link
Member Author

damdo commented May 9, 2025

/assign @sbueringer @mboersma @tamalsaha

@k8s-ci-robot
Copy link
Contributor

@damdo: GitHub didn't allow me to assign the following users: tamalsaha.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sbueringer @mboersma @tamalsaha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo damdo changed the title 🐛 [release-1.9] Relax minLength for bootstrap.dataSecretName to 0 🐛 [release-1.10] Relax minLength for bootstrap.dataSecretName to 0 May 9, 2025
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4fbb96dc60c2563b1ea9e6a217ad314c9d9b7142

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3a5db62 into kubernetes-sigs:release-1.10 May 9, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bootstrap Issues or PRs related to bootstrap providers cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants