✨Auto-select on cluster-name label in MachineDeployment and MachineSet #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
vincepri
force-pushed
the
md-ms-match-labels
branch
from
99a97bc to
837bfa7
Compare
|
lgtm |
ncdc
reviewed
Oct 31, 2019
|
I'd recommend rebasing on top of master now that #1711 is in |
vincepri
force-pushed
the
md-ms-match-labels
branch
from
837bfa7 to
934192f
Compare
|
@ncdc Done |
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
md-ms-match-labels
branch
from
934192f to
36cf145
Compare
|
Actually pushed now :D |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
This PR adds support to auto-select on cluster-name label in MD/MS controllers. It also fixes a 🐛that prevented the
Status.Selectorto not being populated in MachineDeployments./milestone v0.3.0