✨clusterctl: add test framework for move #1977
Conversation
k8s-ci-robot
added
cncf-cla: yes
fabriziopandini
force-pushed
the
clusterctl-move-test-framework
branch
from
8be7724 to
05d6f17
Compare
| @@ -0,0 +1,789 @@ | |||
| /* | |||
There was a problem hiding this comment.
Is this something that we should make available more broadly to the repo? I'm not (necessarily) suggesting that we expose it externally, but it might come in handy for unit/integration testing elsewhere within the repository.
There was a problem hiding this comment.
@detiber now it is designed for testing clusterctl move, but I see your point.
Might be we can merge it as it is, and then eventually move it to the test framework/to somewhere else when there are more clear requirements from the other potential consumers.
There was a problem hiding this comment.
Let's open an issue so we don't forget later on
There was a problem hiding this comment.
Here you go!
#1993
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR is part of the initial work for support for clusterctl move.
It introduces a test framework that allows creating fake v1alpha3 cluster API objects: cluster, control plane, machine deployments, machines etc. with all the ancillary objects (secrets, infrastructureRef or bootstrap.configRef objects etc.)
Which issue(s) this PR fixes
Rif #1729
/assign @vincepri
/cc @detiber (if you can take a look at the fake controlplane implementation 🙏 )