-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨clusterctl: add version command #2061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨clusterctl: add version command #2061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add some documentation around build args on how to use this?
f595a08
to
5f2e5fd
Compare
5f2e5fd
to
6847127
Compare
changing the scope of the PR as discussed in slack |
6847127
to
f5ee663
Compare
f5ee663
to
94376dd
Compare
Nb. I'm ignoring few shell-check errors in the |
That's fair, given the CAPA script is itself taken from k/k |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chuckha ATM I'm not planning to add documentation given that this mirrors what exists in CAPA and that variables are automatically set when building clusterctl |
What this PR does / why we need it:
This PR imports a cleaned version of the
/version
package from CAPA and then implements theclusterctl version
commandrif #1729