Skip to content

✨clusterctl: add version command #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Jan 14, 2020

What this PR does / why we need it:
This PR imports a cleaned version of the /version package from CAPA and then implements the clusterctl version command

rif #1729

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2020
@k8s-ci-robot k8s-ci-robot requested review from justinsb and ncdc January 14, 2020 16:22
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to add some documentation around build args on how to use this?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2020
@fabriziopandini fabriziopandini changed the title ✨add version package ✨clusterctl: add version command Jan 14, 2020
@fabriziopandini
Copy link
Member Author

changing the scope of the PR as discussed in slack

@fabriziopandini
Copy link
Member Author

Nb. I'm ignoring few shell-check errors in the version.sh file to get the validation pass (the script is copy/paste from CAPA)

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 15, 2020
@randomvariable
Copy link
Member

Nb. I'm ignoring few shell-check errors in the version.sh file to get the validation pass (the script is copy/paste from CAPA)

That's fair, given the CAPA script is itself taken from k/k

@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 31ebcaa into kubernetes-sigs:master Jan 15, 2020
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Jan 16, 2020

Would you be able to add some documentation around build args on how to use this?

@chuckha ATM I'm not planning to add documentation given that this mirrors what exists in CAPA and that variables are automatically set when building clusterctl

@fabriziopandini fabriziopandini deleted the add-version-package branch January 16, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants