✨clusterctl: inspect images in provider components #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
62 tasks
ncdc
reviewed
Jan 23, 2020
|
@ncdc comment addressed! |
|
@fabriziopandini forget to push? |
|
@ncdc oops, sorry |
|
LGTM |
|
(will need squashing once vince is 👍 ) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
force-pushed
the
clusterctl-inspect-images
branch
from
fb1c024 to
7f1c28c
Compare
|
@vincepri rebased & squashed |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implement code for detecting images that are required in order to install a provider; this is the initial part of the effort for implementing clusterctl pre-pull images/support for air-gapped environments.
Which issue(s) this PR fixes:
rif #1829
rif #1729
/assign @ncdc
/assign @vincepri