✨clusterctl: add the clusterctl move command #2130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
area/clusterctl
62 tasks
ncdc
reviewed
Jan 23, 2020
| } | ||
|
|
||
| // Ensures the custom resource definitions required by clusterctl are in place. | ||
| if err := fromCluster.ProviderInventory().EnsureCustomResourceDefinitions(); err != nil { |
There was a problem hiding this comment.
Do we need to install the CRDs in the source cluster during move?
There was a problem hiding this comment.
Actually we need the CRDs and all the required providers to be in place.
#2102 contains a TODO for implementing a preflight check for this in the Mover.Move method, and hopefully, this will be addressed next week.
|
@ncdc comment addressed |
fabriziopandini
force-pushed
the
clusterctl-move-cmd
branch
from
3ae78c6 to
bb8a58c
Compare
k8s-ci-robot
added
size/L
fabriziopandini
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR builds on top of #2060, so please consider only that last commit
This PR links the internal code handling the move process with the
clusterctl moveCLI command and also adds the move documentationWhich issue(s) this PR fixes
rif #1729
/area clusterctl
/assign @ncdc
/assign @vincepri