-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨ clusterctl: Add automatic selection of repository backend based on URL #2192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ clusterctl: Add automatic selection of repository backend based on URL #2192
Conversation
Hi @Arvinderpal. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
78ab014
to
a5e57db
Compare
a5e57db
to
e2e8a95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests.
filesystem backend when URL of the repo begins with "file://"
e2e8a95
to
98d51d3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Arvinderpal, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR enables local file system repositories to be included in clusterctl. It identifies a repo as being local by seeing if its URL begins with "file://"
This is a follow up to: #1963
A sample clusterctl config with a local repo may look like this:
Which issue(s) this PR fixes
Rif: #1729
/assign @fabriziopandini
/cc @ncdc @vincepri