Skip to content

✨ clusterctl: Add automatic selection of repository backend based on URL #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Arvinderpal
Copy link
Contributor

What this PR does / why we need it:

This PR enables local file system repositories to be included in clusterctl. It identifies a repo as being local by seeing if its URL begins with "file://"

This is a follow up to: #1963

A sample clusterctl config with a local repo may look like this:

$ cat ~/.cluster-api/clusterctl.yaml 
providers:
- name: infra-foo
  url: file:///home/awander/.cluster-api/infra-foo/v0.1.0/infrastructure-components.yaml
  type: InfrastructureProvider

Which issue(s) this PR fixes
Rif: #1729

/assign @fabriziopandini
/cc @ncdc @vincepri

@k8s-ci-robot k8s-ci-robot requested review from ncdc and vincepri January 28, 2020 23:04
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Arvinderpal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2020
@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2020
@ncdc ncdc added this to the v0.3.0 milestone Jan 29, 2020
@Arvinderpal Arvinderpal force-pushed the clusterctlv2-select-repo-local branch 2 times, most recently from 78ab014 to a5e57db Compare February 4, 2020 14:00
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2020
@Arvinderpal Arvinderpal force-pushed the clusterctlv2-select-repo-local branch from a5e57db to e2e8a95 Compare February 4, 2020 14:23
Copy link
Contributor

@ncdc ncdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests.

filesystem  backend when URL of the repo begins with "file://"
@Arvinderpal Arvinderpal force-pushed the clusterctlv2-select-repo-local branch from e2e8a95 to 98d51d3 Compare February 4, 2020 14:38
@ncdc
Copy link
Contributor

ncdc commented Feb 4, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Arvinderpal, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit bbe403d into kubernetes-sigs:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants