Skip to content

🐛clusterctl: fix public library inconsistencies #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR fixes some inconsistencies in the clusterctl public library, so now all the objects implement a unique approach for injecting values (based on a variadic list of options)

Which issue(s) this PR fixes
rif #1729

/area clusterctl
/milestone v0.3.0
/assign @ncdc
/assign @vincepri

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: You must be a member of the kubernetes-sigs/cluster-api-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

What this PR does / why we need it:
This PR fixes some inconsistencies in the clusterctl public library, so now all the objects implement a unique approach for injecting values (based on a variadic list of options)

Which issue(s) this PR fixes
rif #1729

/area clusterctl
/milestone v0.3.0
/assign @ncdc
/assign @vincepri

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/clusterctl Issues or PRs related to clusterctl size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2020
@fabriziopandini fabriziopandini force-pushed the clusterctl-fix-public-library branch from 420dd38 to 57da6a8 Compare January 31, 2020 16:17
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6f00305 into kubernetes-sigs:master Jan 31, 2020
@fabriziopandini fabriziopandini deleted the clusterctl-fix-public-library branch February 1, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants