🐛clusterctl: preflight for move operation #2313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/clusterctl
62 tasks
wfernandes
reviewed
Feb 13, 2020
| // If we are moving objects in all the namespaces, skip all the providers with a different watching namespace. | ||
| // NB. This introduces a constraints for move all namespaces, that the configuration of source and target provider MUST match (except for the version); | ||
| // however this is acceptable because clusterctl supports only two models of multi-tenancy (n-Infra, n-Core). | ||
| if namespace == "" && !(targetProvider.WatchedNamespace == sourceProvider.WatchedNamespace) { |
There was a problem hiding this comment.
Suggested change
| if namespace == "" && !(targetProvider.WatchedNamespace == sourceProvider.WatchedNamespace) { | |
| if namespace == "" && targetProvider.WatchedNamespace != sourceProvider.WatchedNamespace { |
wfernandes
reviewed
Feb 13, 2020
| args: args{ | ||
| namespace: "", // all namespaces | ||
| toProxy: test.NewFakeProxy(). | ||
| WithProviderInventory("capi", clusterctlv1.CoreProviderType, "v1.0.0", "capi1-system", ""), |
There was a problem hiding this comment.
Suggested change
| WithProviderInventory("capi", clusterctlv1.CoreProviderType, "v1.0.0", "capi1-system", ""), | |
| WithProviderInventory("capi", clusterctlv1.CoreProviderType, "v1.0.0", "capi-system", ""), |
|
Made some minor suggestions. But other than those. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements a preflight check before the move operation that checks if the required providers are in place in the target cluster.
Which issue(s) this PR fixes:
Rif #1729
/area clusterctl
/assign @wfernandes
/assign @vincepri