Skip to content

🌱 [0.3] Backport 3740, 3759, and 3723 #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Oct 9, 2020

What this PR does / why we need it:
/assign @fabriziopandini @sedefsavas
/milestone v0.3.11

vincepri and others added 4 commits October 9, 2020 12:05
This changes the client used to get the machines in a cluster, instead
of using a cached client which could lag behind when the cluster is
under stress or when there are network issues, it uses a live client
reader which causes the request to go directly to the API server.

Signed-off-by: Vince Prignano <[email protected]>
@k8s-ci-robot k8s-ci-robot added this to the v0.3.11 milestone Oct 9, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2020
@vincepri vincepri changed the base branch from master to release-0.3 October 9, 2020 19:22
@sedefsavas
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2020
@vincepri
Copy link
Member Author

vincepri commented Oct 9, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@vincepri
Copy link
Member Author

vincepri commented Oct 9, 2020

/override pull-cluster-api-e2e-main
/override pull-cluster-api-test-main

These are not relevant for this PR, given that it's targeting release-0.3

@k8s-ci-robot
Copy link
Contributor

@vincepri: Overrode contexts on behalf of vincepri: pull-cluster-api-e2e-main, pull-cluster-api-test-main

In response to this:

/override pull-cluster-api-e2e-main
/override pull-cluster-api-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 57a5454 into kubernetes-sigs:release-0.3 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants