Skip to content

🌱 Print provider type and name to match config file naming #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benmoss
Copy link

@benmoss benmoss commented Oct 26, 2020

What this PR does / why we need it:
Changes the log lines printed by clusterctl to be more helpful when trying to create config overrides.

I was head-scratching why my CAPI override was working but my CAPBK wasn't:

providers:
- name: "cluster-api"
  url: "https://github.com/benmoss/cluster-api/releases/latest/core-components.yaml"
  type: "CoreProvider"
- name: "bootstrap-kubeadm"
  url: "https://github.com/benmoss/cluster-api/releases/latest/bootstrap-components.yaml"
  type: "BootstrapProvider"
Fetching File="metadata.yaml" Provider="cluster-api" Version="v0.4.0-rc.1"
Fetching File="metadata.yaml" Provider="bootstrap-kubeadm" Version="v0.3.10"

I inferred from the log lines that the correct "name" for CAPBK would be bootstrap-kubeadm, since cluster-api was the right name for core CAPI.

This changes it to print out the correct name and the provider type as well, so users can more easily infer what they need to put in their override config.

Fetching File="core-components.yaml" Provider="cluster-api" Type="CoreProvider" Version="v0.4.0-rc.1"
Fetching File="bootstrap-components.yaml" Provider="kubeadm" Type="BootstrapProvider" Version="v0.3.10"
Fetching File="control-plane-components.yaml" Provider="kubeadm" Type="ControlPlaneProvider" Version="v0.3.10"
Fetching File="infrastructure-components.yaml" Provider="kubemark" Type="InfrastructureProvider" Version="v0.2.2"
Fetching File="infrastructure-components-development.yaml" Provider="docker" Type="InfrastructureProvider" Version="v0.3.10"
Fetching File="metadata.yaml" Provider="cluster-api" Type="CoreProvider" Version="v0.4.0-rc.1"
Fetching File="metadata.yaml" Provider="kubeadm" Type="BootstrapProvider" Version="v0.3.10"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2020
@benmoss
Copy link
Author

benmoss commented Oct 26, 2020

/area clusterctl

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Oct 26, 2020
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2020
@CecileRobertMichon
Copy link
Contributor

/approve
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3aac2fc into kubernetes-sigs:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants