Porting owners file from kube-deploy #4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # See the OWNERS docs: https://git.k8s.io/community/contributors/devel/owners.md | ||
|
|
||
| approvers: | ||
| - sig-cluster-lifecycle-leads | ||
| - cluster-api-admins | ||
| - cluster-api-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # See the OWNERS docs: https://git.k8s.io/community/docs/devel/owners.md | ||
|
|
||
| aliases: | ||
| sig-cluster-lifecycle-leads: | ||
| - lukemarsden | ||
| - luxas | ||
| - roberthbailey | ||
| - timothysc | ||
| cluster-api-admins: | ||
| - justinsb | ||
|
There was a problem hiding this comment. Justin was a kube-deploy admin for the aws image builder sub-project. Not sure if he cares about being an admin for this repo or not. |
||
| - krousey | ||
| - luxas | ||
|
There was a problem hiding this comment. I agree that he should be in the sig leads and part of approvers. I think he was a kube-deploy admin, but not very active in the cluster-api aspect of it. @luxas, does that seem accurate? |
||
| - roberthbailey | ||
| - kris-nova | ||
| cluster-api-maintainers: | ||
| - jessicaochen | ||
| - karan | ||
| - kris-nova | ||
| - krousey | ||
| - medinatiger | ||
| - roberthbailey | ||
| - rsdcastro | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this come with github repo privileges like being able to create labels and other things? Is this meant to mirror that structure? If so, then this list should mirror the github organizational structure. It's fine to discuss who should have that level of access here though and then mirror it back to github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the kube-deploy repo, this list came from the github group with the same name. If we aren't going to be setting up groups in this org then there isn't any point separating out admins from maintainers here.