🌱 PoC: golang-ci-lint exclude #4654
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
|
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -43,7 +43,7 @@ issues: | |||
| exclude-use-default: false | |||
| # List of regexps of issue texts to exclude, empty list by default. | |||
| exclude: | |||
| - Using the variable on range scope `(tc)|(rt)|(tt)|(test)|(testcase)|(testCase)` in function literal | |||
| - Using the variable on range scope .* in function literal | |||
| - "G108: Profiling endpoint is automatically exposed on /debug/pprof" | |||
| - Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?Setenv). is not checked | |||
There was a problem hiding this comment.
That one could be similarly dangerous
| @@ -43,7 +43,7 @@ issues: | |||
| exclude-use-default: false | |||
| # List of regexps of issue texts to exclude, empty list by default. | |||
| exclude: | |||
| - Using the variable on range scope `(tc)|(rt)|(tt)|(test)|(testcase)|(testCase)` in function literal | |||
| - Using the variable on range scope .* in function literal | |||
There was a problem hiding this comment.
Not a real fix, but scopelint should be replaced by exportloopref via #4649 anyway
|
great catch! |
credits to @enxebre for the initial finding: #4649 (comment) |
|
will be fixed in: #4657 /close |
|
@sbueringer: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Just intended to show how many issues we ignored accidentally.
Related to #4649 (comment)