Skip to content

📖 doc: add linter fix hint to migration doc #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021
Merged

📖 doc: add linter fix hint to migration doc #4664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,3 +277,10 @@ MachinePool is today an experiment, and the API group we originally decided to p
All InfraMachinePool implementations should be moved to `infrastructure.cluster.x-k8s.io`. See `DockerMachinePool` for an example.

Note that MachinePools are still experimental after this change and should still be feature gated.

## Golangci-lint configuration

There were a lot of new useful linters added to `.golangci.yml`. Of course it's not mandatory to use `golangci-lint` or
a similar configuration, but it might make sense regardless. Please note there was previously an error in
the `exclude` configuration which has been fixed in [#4657](https://github.com/kubernetes-sigs/cluster-api/pull/4657). As
this configuration has been duplicated in a few other providers, it could be that you're also affected.