Skip to content

⚠️ Enforce comments on most of the codebase #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

⚠️ Enforce comments on most of the codebase #4669

merged 1 commit into from
May 25, 2021

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

Marked as a breaking change because we're unexporting some previously
exported variables or structs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/milestone v0.4
/assign @CecileRobertMichon @fabriziopandini @sbueringer

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone May 25, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2021
@vincepri
Copy link
Member Author 

sigs.k8s.io/cluster-api/cmd/clusterctl/cmd
  Incompatible changes:
  - Indentation: removed
sigs.k8s.io/cluster-api/util/conditions
  Incompatible changes:
  - ConditionMatcher: removed
+ EXIT_VALUE=1
+ set +o xtrace

JoelSpeed
JoelSpeed reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me on this change, found one comment description that doesn't quite parse for me though, PTAL

util/collections/machine_filters.go Outdated
@@ -26,6 +26,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client"
)

// Func defines is the functon definition for a filter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one reads a bit odd to me, is the word defines extra?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fixing in a bit

@sedefsavas sedefsavas mentioned this pull request May 25, 2021
Closed
@CecileRobertMichon
Copy link
Contributor

lgtm aside from Joel's comment above

@vincepri
⚠️ Enforce comments on most of the codebase
6db0dc8 
Marked as a breaking change because we're unexporting some previously
exported variables or structs.

Signed-off-by: Vince Prignano <[email protected]>
@vincepri vincepri force-pushed the enfoce-golint-comments branch from a742390 to 6db0dc8 Compare May 25, 2021 17:35
@vincepri
Copy link
Member Author

/retest

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@fabriziopandini
Copy link
Member

/test pull-cluster-api-test-main

1 similar comment
@fabriziopandini
Copy link
Member

/test pull-cluster-api-test-main

@vincepri
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 25, 2021 •
edited
Loading

@vincepri: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main 6db0dc8 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit c680379 into kubernetes-sigs:master May 25, 2021
@CecileRobertMichon CecileRobertMichon mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
6 participants
@vincepri @CecileRobertMichon @fabriziopandini @k8s-ci-robot @JoelSpeed @sbueringer