🐛 fix golangci-lint nolint:ifshort

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
I just set up my local environment on mac and got the following error:

controllers/machine_controller.go:276:36: directive `// nolint:ifshort` is unused for linter "ifshort" (nolintlint)
isDeleteNodeAllowed := err == nil // nolint:ifshort

When I remove the nolint I get a finding of the ifshort linter, so we definitely need the nolint. I'm not sure why we don't get the error in CI but apparently all our other nolint's don't have a space between // and nolint.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[fabriziopandini]

/lgtm

[neolit123]

I think the linter is getting confused.
Instead of adding a pragma i would have moved the code a bit. E.g. have foo = true in the err == nil branch.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [neolit123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

I think the linter is getting confused.
Instead of adding a pragma i would have moved the code a bit. E.g. have foo = true in the err == nil branch.

/approve

@neolit123 I can change could have changed it to:

	isDeleteNodeAllowed := false
	if err != nil {
		switch err {
		case errNoControlPlaneNodes, errLastControlPlaneNode, errNilNodeRef, errClusterIsBeingDeleted, errControlPlaneIsBeingDeleted:
			log.Info("Deleting Kubernetes Node associated with Machine is not allowed", "node", m.Status.NodeRef, "cause", err.Error())
		default:
			return ctrl.Result{}, errors.Wrapf(err, "failed to check if Kubernetes Node deletion is allowed")
		}
	} else {
		isDeleteNodeAllowed = true
	}

Although I'm not sure which version is easier readable.

[neolit123]

Although I'm not sure which version is easier readable.

The version with the pragma seems fine too.