Skip to content

🐛 Missing watch label to allow multiple manager instances #4929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

🐛 Missing watch label to allow multiple manager instances #4929

merged 1 commit into from
Jul 19, 2021

Conversation

fiunchinho
Copy link
Contributor

@fiunchinho fiunchinho commented Jul 13, 2021 •
edited
Loading

What this PR does / why we need it:

In this PR we added the watch label to be able to run multiple manager instances, but we missed some controllers. This PR fixes that.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @fiunchinho. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2021
@fiunchinho fiunchinho changed the title Missing watch filter Missing watch label Jul 13, 2021
@fiunchinho fiunchinho changed the title Missing watch label 🐛 Missing watch label Jul 13, 2021
@fiunchinho fiunchinho marked this pull request as ready for review July 13, 2021 10:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2021
@fiunchinho fiunchinho changed the title 🐛 Missing watch label 🐛 Missing watch label to allow multiple manager instances Jul 13, 2021
@MarcelMue
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2021
@MarcelMue
Copy link
Contributor

Looks good to me in general - I missed these in my initial PR and they have lived in our forks only until now.

@fiunchinho fiunchinho force-pushed the missing-watch-filter branch from 514fc9d to cc9a9da Compare July 19, 2021 11:16
@sbueringer
Copy link
Member

sbueringer commented Jul 19, 2021 •
edited
Loading

Thank you!!

/lgtm

(Hint: commits have to be squashed before merge)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@fiunchinho
Add watch-filter support to ClusterCacheReconciler
9fbe827 
Add watch-filter support to kubeadm bootstrap controller

Add event filtering based on optional watch-filter parameter to kubeadm
boostrap controller.

Add watch-filter support to kubeadm controlplane controller
@fiunchinho fiunchinho force-pushed the missing-watch-filter branch from cc9a9da to 9fbe827 Compare July 19, 2021 15:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@fiunchinho
Copy link
Contributor Author

Done. Thanks!

@MarcelMue
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@sbueringer
Copy link
Member

/lgtm

vincepri
vincepri approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 604a465 into kubernetes-sigs:master Jul 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jul 19, 2021
@fiunchinho fiunchinho deleted the missing-watch-filter branch August 3, 2021 15:44
@fiunchinho fiunchinho mentioned this pull request Aug 18, 2021
Merged
3 tasks
@fiunchinho fiunchinho mentioned this pull request Oct 9, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

@MarcelMue MarcelMue

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@fiunchinho @k8s-ci-robot @MarcelMue @sbueringer @vincepri