🌱 Promote sbueringer to cluster-api-test maintainer #5504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
requested review from
CecileRobertMichon,
fabriziopandini and
vincepri
k8s-ci-robot
added
cncf-cla: yes
sbueringer
changed the title
|
Huge +1 🎉 /lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
+1 |
1 similar comment
|
+1 |
|
+1 |
|
+1 |
|
/lgtm Thanks for all your work! |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
vincepri
approved these changes
Nov 4, 2021
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR adds @sbueringer (myself ;)) to cluster-api-test-maintainers.
I think I've been (helping) maintaining our test framework, e2e tests and CAPD for a while now. Mostly keeping testgrid green, tracking down and fixing broken or flaky tests, maintaining ProwJob configurations and of course also reviewing PRs in those areas, etc. .
I don't think we have the data quality to filter down for those specific areas so I'll just list all CAPI contributions:
PRs: https://github.com/kubernetes-sigs/cluster-api/pulls?q=is%3Apr+is%3Aclosed+author%3Asbueringer
Reviews: https://github.com/kubernetes-sigs/cluster-api/pulls?page=1&q=is%3Apr+sbueringer
Issues: https://github.com/kubernetes-sigs/cluster-api/issues?q=is%3Aissue+author%3Asbueringer+
test-infra (cluster-api) PRs: https://github.com/kubernetes/test-infra/pulls?q=is%3Apr+author%3Asbueringer+is%3Aclosed+cluster-api
/cc @vincepri @fabriziopandini @CecileRobertMichon
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #