✨ Add BringYourOwnHost(BYOH) provider to clusterctl

[shamsher31]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes vmware-tanzu/cluster-api-provider-bringyourownhost#202

[k8s-ci-robot]

Welcome @shamsher31!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @shamsher31. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabriziopandini]

/ok-to-test

[fabriziopandini]

@shamsher31 thanks for your first PR in CAPI!
looking forward to see a demo of this provider in the community meeting!

fyi, people usually add new providers also in

• https://cluster-api.sigs.k8s.io/reference/providers.html
• https://cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#labels

[shamsher31]

/retest

[anusha94]

/assign @fabriziopandini @sbueringer

[sbueringer]

/lgtm

PR looks fine to me.

@anusha94 @shamsher31 I'm not entirely sure about the published infrastructure-components.yaml on the provider. If I got it correctly, the resources should be labeled with cluster.x-k8s.io/provider=infrastructure-byoh. I'm not sure if there will be problems with clusterctl without this label.

The components YAML components should be labeled with cluster.x-k8s.io/provider and the name of the provider.
This will enable an easier transition from kubectl apply to clusterctl.
https://cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#labels

[shamsher31]

@anusha94 @shamsher31 I'm not entirely sure about the published infrastructure-components.yaml on the provider. If I got it correctly, the resources should be labeled with cluster.x-k8s.io/provider=infrastructure-byoh. I'm not sure if there will be problems with clusterctl without this label.

@sbueringer Thanks for the review, we are working on adding the label here vmware-tanzu/cluster-api-provider-bringyourownhost#212

[fabriziopandini]

/approve
yay!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment