Skip to content

📖 Add new fix for Docker inotify troubleshooting #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

📖 Add new fix for Docker inotify troubleshooting #6104

merged 1 commit into from
Feb 11, 2022

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon [email protected]

Adds information to point users to a Docker Desktop upgrade when they encounter the 'too many files' issue on Docker Desktop for Mac / CAPD.

Fixes #5940

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2022
@sbueringer
Copy link
Member

sbueringer commented Feb 11, 2022 •
edited
Loading

/lgtm

Fine to keep it now but at some point I would drop the workaround from the book (a few months - a year from now or so, if anyone remembers it then)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2022
@killianmuldoon
Copy link
Contributor Author

Who knows if this will have a regression 😄. But yeah, we can't keep building up small fixes for every point version in third party dev tools.

@sbueringer
Copy link
Member

Prow plugin idea (stolen from slack) 😂

/remind @killianmuldoon "Update Docker troubleshooting doc" in 365 days

Would be great if someone can implement that :)

vincepri
vincepri approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2022
@fabriziopandini
Copy link
Member

Now I can finally upgrade docker 😜

@k8s-ci-robot k8s-ci-robot merged commit 8fd2147 into kubernetes-sigs:main Feb 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Docker Desktop >= 4.3.* for MacOS: unable to create workload cluster with CAPD
5 participants
@killianmuldoon @sbueringer @k8s-ci-robot @fabriziopandini @vincepri