-
Notifications
You must be signed in to change notification settings - Fork 1.4k
📖 Add cluster-resource-set-controller to docs #6782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add cluster-resource-set-controller to docs #6782
Conversation
Hi @ramineni. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f918a3d
to
e2d4aa8
Compare
/assign @killianmuldoon |
/ok-to-test /cc @killianmuldoon |
docs/book/src/developer/architecture/controllers/cluster-resource-set.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/cluster-resource-set.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/cluster-resource-set.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/cluster-resource-set.md
Outdated
Show resolved
Hide resolved
e2d4aa8
to
5ceabac
Compare
@killianmuldoon updated. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit - could you move the position in Summary.md to Just below the ClusterTopology controller?
5ceabac
to
7525941
Compare
Thx! Please squash the commits, otherwise lgtm from my side |
3d5c8d3
to
28f4931
Compare
/lgtm |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@sbueringer: new pull request created: #6798 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Add a documentation page on ClusterResourceSet controller
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5475