Skip to content

📖 Add cluster-resource-set-controller to docs #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ramineni
Copy link
Contributor

What this PR does / why we need it:
Add a documentation page on ClusterResourceSet controller
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5475

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ramineni. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 30, 2022
@ramineni ramineni changed the title Add cluster-resource-set-controller to docs 📖 Add cluster-resource-set-controller to docs Jun 30, 2022
@ramineni ramineni force-pushed the add-clusterresourceset-controller-docs branch 2 times, most recently from f918a3d to e2d4aa8 Compare June 30, 2022 05:03
@ramineni
Copy link
Contributor Author

/assign @killianmuldoon

@sbueringer
Copy link
Member

/ok-to-test

/cc @killianmuldoon

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2022
@ramineni ramineni force-pushed the add-clusterresourceset-controller-docs branch from e2d4aa8 to 5ceabac Compare June 30, 2022 11:37
@ramineni
Copy link
Contributor Author

@killianmuldoon updated. PTAL

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit - could you move the position in Summary.md to Just below the ClusterTopology controller?

@ramineni ramineni force-pushed the add-clusterresourceset-controller-docs branch from 5ceabac to 7525941 Compare July 1, 2022 04:24
@sbueringer
Copy link
Member

Thx!

Please squash the commits, otherwise lgtm from my side

@ramineni ramineni force-pushed the add-clusterresourceset-controller-docs branch from 3d5c8d3 to 28f4931 Compare July 1, 2022 11:29
@sbueringer
Copy link
Member

/lgtm
/approve
/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
@killianmuldoon
Copy link
Contributor

/lgtm

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #6798

In response to this:

/lgtm
/approve
/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for controllers missing from book
5 participants