📖 fixing clusterctl.exe installation directions for curl.exe

[luthermonson]

What this PR does / why we need it:
Fixes clusterctl.exe installation on Windows, first it was missing the -L for the redirect and was returning empty content for the http request. but... curl is sometimes an alias in PowerShell for Invoke-WebRequest so the best and most cross compatible way for cmd and powershell I ever found was to just call curl.exe explicitly which always ends up being the curl everyone expects.

This is what happens using the docs as they exist today in powershell

~ > curl https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.2.0/clusterctl-windows-amd64.exe -o clusterctl.exe
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
~ > get-content .\clusterctl.exe
~ > clusterctl
ResourceUnavailable: Program 'clusterctl.exe' failed to run: An error occurred trying to start process 'C:\Users\luthe\bin\clusterctl.exe' with working directory 'C:\Users\luthe'. The specified executable is not a valid application for this OS platform.At line:1 char:1
+ clusterctl
+ ~~~~~~~~~~.

This is what happens after this patch

~ > curl -L https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.2.0/clusterctl-windows-amd64.exe -o clusterctl.exe
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 61.6M  100 61.6M    0     0  26.6M      0  0:00:02  0:00:02 --:--:-- 33.8M
~ > .\clusterctl.exe version
clusterctl version: &version.Info{Major:"1", Minor:"2", GitVersion:"v1.2.0", GitCommit:"aebeed871c780cfc71bc292dd59eed381da0771f", GitTreeState:"clean", BuildDate:"2022-07-18T14:52:17Z", GoVersion:"go1.18.3", Compiler:"gc", Platform:"windows/amd64"}

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

Welcome @luthermonson!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @luthermonson. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

Thanks for fixing this up! We definitely have a problem reviewing Windows workflows 🙂 Hopefully someone who can run this locally is able to confirm it's the right approach!

[luthermonson]

@killianmuldoon can this get merged?

[killianmuldoon]

@killianmuldoon can this get merged?

I'd prefer to wait until other Windows-using folks chime in here to be sure this is the correct solution. I'll raise it in the slack channel and see if anyone can help.

[jackfrancis]

cc @marosset

[marosset]

@killianmuldoon can this get merged?

I'd prefer to wait until other Windows-using folks chime in here to be sure this is the correct solution. I'll raise it in the slack channel and see if anyone can help.

Using curl.exe for windows instead of the curl powershell alias is my recommended approach.
These will work in either powershell or cmd
I made recently made the same suggestions in k/website :)

/ok-to-test
/lgtm

[killianmuldoon]

Thanks for helping review this @marosset!

/lgtm

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[killianmuldoon]

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@killianmuldoon: new pull request created: #7048

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.