✨ add NodeVolumeDetachTimeout support for Cluster Topology #7235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
ykakarap
force-pushed
the
cluser-topology_NodeVolumeDetachTimeout
branch
2 times, most recently
from
bbd951c to
1d500d6
Compare
k8s-ci-robot
added
the
needs-rebase
ykakarap
force-pushed
the
cluser-topology_NodeVolumeDetachTimeout
branch
from
1d500d6 to
9c71915
Compare
k8s-ci-robot
added
size/M
ykakarap
changed the title
k8s-ci-robot
removed
the
do-not-merge/hold
sbueringer
reviewed
Sep 21, 2022
k8s-ci-robot
added
size/L
sbueringer
reviewed
Sep 22, 2022
|
lgtm pending Stefan comment, great work! |
ykakarap
force-pushed
the
cluser-topology_NodeVolumeDetachTimeout
branch
from
f0dfd46 to
61b12f4
Compare
|
Thx! lgtm pending squash |
ykakarap
force-pushed
the
cluser-topology_NodeVolumeDetachTimeout
branch
from
61b12f4 to
1280aca
Compare
|
Squashed. |
k8s-ci-robot
added
the
lgtm
|
Thx! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add NodeVolumeDetachTimeout support for Cluster Topology.
NodeVolumeDetachTimeout is introduced in #6413.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #7233
/hold until #6413 is merged.