Skip to content

📖 document automatic certificate renewal support in KCP #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2022
Merged

📖 document automatic certificate renewal support in KCP #7268

merged 3 commits into from
Nov 7, 2022

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR documents about the new automatic control plane certificate renewal support through repave in KCP.
The feature was introduced in: #6983

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7247

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2022
@ykakarap
Copy link
Contributor Author

This is still an early draft.

@ykakarap ykakarap force-pushed the docs_certificate_rollout_kcp branch from 3749e82 to fe295a5 Compare September 21, 2022 23:26
fabriziopandini
fabriziopandini reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great start, I have added few suggestions
also, this page should be linked from the index

@fabriziopandini
Copy link
Member

Great work, IMO you can remove WIP and squash commits
@sbueringer PTAL when you have time

sbueringer
sbueringer reviewed Sep 29, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits,

@ykakarap ykakarap changed the title 📖 [WIP]document automatic certificate renewal support in KCP 📖 document automatic certificate renewal support in KCP Sep 29, 2022
@ykakarap ykakarap force-pushed the docs_certificate_rollout_kcp branch from 56b8afc to 96b06c9 Compare September 30, 2022 00:56
@ykakarap ykakarap mentioned this pull request Sep 30, 2022
Closed
fabriziopandini
fabriziopandini reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two last nits, otherwise lgtm

@fabriziopandini fabriziopandini mentioned this pull request Oct 3, 2022
Closed
@ykakarap ykakarap mentioned this pull request Oct 4, 2022
Closed
@ykakarap ykakarap force-pushed the docs_certificate_rollout_kcp branch from 96b06c9 to 9da9118 Compare October 4, 2022 18:55
fabriziopandini
fabriziopandini reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2022
@sbueringer
Copy link
Member

/lgtm

@sbueringer
Copy link
Member

/hold
for a bit. If #7342 (comment) works out we can simplify the documentation a bit

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2022
@sbueringer sbueringer mentioned this pull request Oct 6, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2022
@ykakarap ykakarap force-pushed the docs_certificate_rollout_kcp branch from 9da9118 to 8c4ea2e Compare November 2, 2022 01:06
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2022
@ykakarap
Copy link
Contributor Author

ykakarap commented Nov 2, 2022 •
edited
Loading

@sbueringer I have updated the documentation to match the new changes made to the certificate rotation feature. PTAL.

We will need to definitely get this into the v1.3 release.

@sbueringer
Copy link
Member

Will definitely review this week. Flagged the corresponding issue as release-blocking just to make it easier to track

@sbueringer
Copy link
Member

@ykakarap Did another review.

fabriziopandini
fabriziopandini reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, only one minor nit from my side

@ykakarap ykakarap force-pushed the docs_certificate_rollout_kcp branch from 8c4ea2e to 0ec048a Compare November 4, 2022 01:14
@sbueringer
Copy link
Member

Thank you!

lgtm pending squash

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 7, 2022
@sbueringer
Copy link
Member

/lgtm
/approve

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6f32637 into kubernetes-sigs:main Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri left review comments

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Document about the newly added support for certificate rotation through machine repave in KCP in CAPI book
5 participants
@ykakarap @fabriziopandini @sbueringer @k8s-ci-robot @vincepri