Skip to content

📖 Managed Kubernetes Feature Group #7546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jackfrancis
Copy link
Contributor

What this PR does / why we need it:

This PR defines a Working Group to codify where formal conversations and progress is being made in Cluster API for standardizing Managed Kubernetes solutions across the provider ecosystem.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2022
@oscr
Copy link
Contributor

oscr commented Nov 16, 2022

Really interesting initiative.

cc @joekr

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think the base idea is really good - just a little bit unsure as to how this gels with the K8s community definition and processes around working groups:

Would it be easier to drop the term "working group" and adopt some similar alternative to keep the lighter-weight process, but avoid confustion between this and a K8s community working group?

Another nit 🙂 - maybe this could go in /docs/community instead of /docs/proposals

@jackfrancis
Copy link
Contributor Author

@killianmuldoon good point about the already defined k8s concept of a "working group" (which in my understanding is meant to suggest an inter-team or team-of-teams thing, and less a breakout from one particular team).

How about:

  • Focus Group
  • Feature Group
  • Workstream Group
  • Splinter Group (+1 for 80s action movie vibes)

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!
+1 to Killian comments (I kind of like Focus group for the name, but no strong preference)
just added some suggestion, but I think that it is fair also to let the group to work defining deliverables and improving communications patterns over time

@jackfrancis jackfrancis changed the title 📖 Managed Kubernetes Working Group 📖 Managed Kubernetes Feature Group Dec 1, 2022
@jackfrancis jackfrancis force-pushed the working-group-managed-k8s branch from e57ac22 to 64407ba Compare December 6, 2022 18:44
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@jackfrancis jackfrancis force-pushed the working-group-managed-k8s branch from 64407ba to 4726744 Compare December 6, 2022 18:48
@richardcase
Copy link
Member

Looking forward to the inaugural meeting. From my side:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@jackfrancis jackfrancis force-pushed the working-group-managed-k8s branch from 4726744 to 2e29f6f Compare December 7, 2022 18:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@jackfrancis
Copy link
Contributor Author

@fabriziopandini @sbueringer @killianmuldoon are we willing to consider merging this at this point?

@fabriziopandini
Copy link
Member

Great to see this moving
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@pydctw
Copy link

pydctw commented Dec 12, 2022

Thanks @jackfrancis for putting this together.
/lgtm

@killianmuldoon
Copy link
Contributor

/lgtm

Thanks for pioneering the feature group!

@sbueringer
Copy link
Member

Last two open conversations, otherwise I'm fine with merging ASAP.

@jackfrancis jackfrancis force-pushed the working-group-managed-k8s branch from 2e29f6f to f15077b Compare January 4, 2023 21:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@sbueringer
Copy link
Member

@jackfrancis Thank you very much for driving this!

Given lgtm's above + only minor changes afterwards

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 587e2cdbb33a6bac7029bf0b18bc44e9bebd35d0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit df9c56c into kubernetes-sigs:main Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 5, 2023
@jackfrancis jackfrancis deleted the working-group-managed-k8s branch January 17, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.