Skip to content

Integration test skeleton #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

Integration test skeleton #800

merged 1 commit into from
Mar 13, 2019

Conversation

pablochacin
Copy link
Contributor

@pablochacin pablochacin commented Mar 2, 2019 •
edited
Loading

This is an initial version of the test code. It is not yet integrated into CI test.

What this PR does / why we need it:

Complements PR-755 implementing an skeleton for integration tests based on events.

Fixes #11

TODO

  • Implement skeleton
  • Test locally
  • Integrate into ci scripts
  • Test in CI environment

Special notes for your reviewer:

Code submitted for review of the proposed test approach.

cc @figo

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @pablochacin. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2019
ncdc
ncdc reviewed Mar 4, 2019
View reviewed changes
figo
figo reviewed Mar 4, 2019
View reviewed changes
@figo figo mentioned this pull request Mar 5, 2019
Merged
@figo
Copy link
Contributor

figo commented Mar 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2019
@figo
Copy link
Contributor

figo commented Mar 5, 2019 •
edited
Loading

/lgtm cancel
@pablochacin you will need to run ./hack/update-bazel.sh to generate the BUILD.bazel in folder.
and add copyright header for the file.

finally run scripts/ci-test.sh should pass

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2019
@pablochacin
Copy link
Contributor Author

pablochacin commented Mar 6, 2019 •
edited
Loading

@figo I addressed your comments. Thanks for pointing out the copyright! I also changed the package to integration (it was deployment not sure why)
Regarding the scripts/ci-test.sh I cannot test it locally as I get an OS linux not supported message.-

@figo
Copy link
Contributor

figo commented Mar 6, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2019
@figo
Copy link
Contributor

figo commented Mar 6, 2019

@figo I addressed your comments. Thanks for pointing out the copyright! I also changed the package to integration (it was deployment not sure why)
Regarding the scripts/ci-test.sh I cannot test it locally as I get an OS linux not supported message.-

do you know which line the error comes from? running on linux is fine (ci is running with Linux container)

btw, the latest failure shows you need to push the updated vendor files
but please make sure scripts/ci-test.sh, scripts/ci-build.sh, scripts/ci-make.sh pass locally.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2019
@ncdc
Copy link
Contributor

ncdc commented Mar 6, 2019

/milestone v1alpha1

@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Mar 6, 2019
@pablochacin pablochacin changed the title WIP: Integration test skeleton Integration test skeleton Mar 6, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2019
@figo
Copy link
Contributor

figo commented Mar 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@figo
Copy link
Contributor

figo commented Mar 7, 2019

/assign @ncdc

ncdc
ncdc suggested changes Mar 7, 2019
View reviewed changes
@ncdc
Copy link
Contributor

ncdc commented Mar 7, 2019

I'm used to seeing commits that modify vendored dependencies separated from commits that modify this repository's source code. @detiber have you all been following that practice here?

@detiber
Copy link
Member

detiber commented Mar 7, 2019

@ncdc If we wanted to enforce that here we'd also have to leverage separate PRs, since the default policy for the cluster-api* repos is to squash merge (I believe that is the default for at least kubernetes-sigs repos, if not all kubernetes managed repos)

@ncdc
Copy link
Contributor

ncdc commented Mar 7, 2019

Ok, just checking. Not a big deal.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@pablochacin
Copy link
Contributor Author

@ncdc @figo I think I addressed all your concerns.

Integration test skeleton
2ce0aa0 
Introduces an skeleton for integration tests
using the events generated by the test provider.
Signed-off-by: Pablo Chacin <[email protected]>
@figo
Copy link
Contributor

figo commented Mar 12, 2019

/test pull-cluster-api-test

@figo
Copy link
Contributor

figo commented Mar 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@ncdc
Copy link
Contributor

ncdc commented Mar 13, 2019

/lgtm
/approve

@ncdc
Copy link
Contributor

ncdc commented Mar 13, 2019

/assign @vincepri

vincepri
vincepri approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

/approve

test/integration/cluster/cluster_test.go
}

// Timeout for waiting events in seconds
const TIMEOUT = 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this a test flag with default to 60s?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, pablochacin, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 09b15f6 into kubernetes-sigs:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figo figo figo left review comments

@ncdc ncdc ncdc approved these changes

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@ncdc ncdc

@figo figo

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1alpha1
Development

Successfully merging this pull request may close these issues.
6 participants
@pablochacin @k8s-ci-robot @figo @ncdc @detiber @vincepri