Skip to content

🌱 Release v1.4.8 #9600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

🌱 Release v1.4.8 #9600

merged 1 commit into from
Oct 24, 2023

Conversation

g-gaston
Copy link
Contributor

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2023
furkatgofurov7
furkatgofurov7 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the current state, however, we might need to re-generate notes once again to double-check we don't have a diff commits. As of now the missing ones are: 372b48a and dbcdc8c

/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
killianmuldoon
killianmuldoon reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9e2195cb732f1c9499e93761164183bab75c5f98

@g-gaston g-gaston force-pushed the notes-release-1.4.8 branch from c996024 to da3fc71 Compare October 24, 2023 14:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@g-gaston
Copy link
Contributor Author

Need a new lgtm, I removed the extra --- line

killianmuldoon
killianmuldoon reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 58d1c1f55a0e35266d805f81bf7a94365504de62

@killianmuldoon
Copy link
Contributor

@g-gaston can you retitle this to fit the older release PR style?

@g-gaston g-gaston changed the title 🚀 Release v1.4.8 🌱 Release v1.4.8 Oct 24, 2023
@nawazkh
Copy link
Member

nawazkh commented Oct 24, 2023

/lgtm

@furkatgofurov7
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0957353 into kubernetes-sigs:main Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@cahillsf cahillsf Awaiting requested review from cahillsf

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@nawazkh nawazkh

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@g-gaston @k8s-ci-robot @killianmuldoon @nawazkh @furkatgofurov7