feature request: fake client should try to automatically determine objects with subresources #2386
Labels
kind/support
Categorizes issue or PR as a support question.
Comments
|
No, because while enabling the status subresource requires a status field the inverse isn't true, having a status field doesn't mean you have to enable the status subresource. It's simply a setting on the CRD. As a result, it's not possible to automatically detect that. |
|
re: "it's not possible to automatically detect that" - yep, that's the feature request. i'm not super opinionated about the implementation. i another way i could think of is to have the |
That information is not available to the fake client, you need the source code of the CRD for that. "it is not possible" means what it says on the tin. If you just pass in a type we can't infer from it if it has a status subresource or not. You will need to pass in something else. It was discussed that we could infer this from the CRD which would work, but that would still require passing in the CRD. So one way or another, it has to be explicitly configured. |
10 tasks
|
Are you still having issues with this @nicks ? Can this be closed? |
|
/kind support |
k8s-ci-robot
added
the
kind/support
|
Closing in response to the above answers. If this is still causing problems, please feel free to reopen. |
|
@troy0820: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
carlosrejano
added a commit
to carlosrejano/argo-cd
that referenced
this issue
Aug 23, 2024
# Context: When updating the status of the applicationset object it can happen that it fails due to a conflict since the resourceVersion has changed due to a different update. This makes the reconcile fails and we need to wait until the following reconcile loop until it updates the relevant status fields and hope that the update calls don't fail again due a conflict. It can even happen that it gets stuck constantly due to this erriors. A better approach I would say is retrying when there is a conflict error with the newest version of the object, so we make sure we update the object with the latest version always. This has been raised in issue argoproj#19535 that failing due to conflicts can make the reconcile not able to proceed. # What does this PR? - Wraps all the `Update().Status` calls inside a retry function that will retry when the update fails due a conflict. - Adds appset to fake client subresources, if not the client can not correctly determine the status subresource. Refer to: kubernetes-sigs/controller-runtime#2386, and kubernetes-sigs/controller-runtime#2362. Signed-off-by: Carlos Rejano <[email protected]>
carlosrejano
added a commit
to carlosrejano/argo-cd
that referenced
this issue
Aug 23, 2024
# Context: When updating the status of the applicationset object it can happen that it fails due to a conflict since the resourceVersion has changed due to a different update. This makes the reconcile fails and we need to wait until the following reconcile loop until it updates the relevant status fields and hope that the update calls don't fail again due a conflict. It can even happen that it gets stuck constantly due to this erriors. A better approach I would say is retrying when there is a conflict error with the newest version of the object, so we make sure we update the object with the latest version always. This has been raised in issue argoproj#19535 that failing due to conflicts can make the reconcile not able to proceed. # What does this PR? - Wraps all the `Update().Status` calls inside a retry function that will retry when the update fails due a conflict. - Adds appset to fake client subresources, if not the client can not correctly determine the status subresource. Refer to: kubernetes-sigs/controller-runtime#2386, and kubernetes-sigs/controller-runtime#2362. Signed-off-by: Carlos Rejano <[email protected]>
gdsoumya
pushed a commit
to argoproj/argo-cd
that referenced
this issue
Sep 7, 2024
* fix(appset): Retry on conflict when updating status # Context: When updating the status of the applicationset object it can happen that it fails due to a conflict since the resourceVersion has changed due to a different update. This makes the reconcile fails and we need to wait until the following reconcile loop until it updates the relevant status fields and hope that the update calls don't fail again due a conflict. It can even happen that it gets stuck constantly due to this erriors. A better approach I would say is retrying when there is a conflict error with the newest version of the object, so we make sure we update the object with the latest version always. This has been raised in issue #19535 that failing due to conflicts can make the reconcile not able to proceed. # What does this PR? - Wraps all the `Update().Status` calls inside a retry function that will retry when the update fails due a conflict. - Adds appset to fake client subresources, if not the client can not correctly determine the status subresource. Refer to: kubernetes-sigs/controller-runtime#2386, and kubernetes-sigs/controller-runtime#2362. Signed-off-by: Carlos Rejano <[email protected]> * fixup! fix(appset): Retry on conflict when updating status --------- Signed-off-by: Carlos Rejano <[email protected]> Signed-off-by: carlosrejano <[email protected]> Co-authored-by: Carlos Rejano <[email protected]>
oleksandr-codefresh
added a commit
to codefresh-io/argo-cd
that referenced
this issue
Jan 9, 2025
* chore: remove unused params (#19473) * chore: remove unused params Signed-off-by: Michael Crenshaw <[email protected]> * more Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> * fix: selfHeal should always be respected with Multi-Source Apps #19452 (#19512) * fix(controller): selfHeal respected in multi-source apps when there is object change in cluster Signed-off-by: Eric Lin <[email protected]> * fix: tests for multi source selfheal Signed-off-by: Ezzahhh <[email protected]> --------- Signed-off-by: Eric Lin <[email protected]> Signed-off-by: Ezzahhh <[email protected]> * chore(deps): bump library/registry in /test/container (#19207) Bumps library/registry from `79b2959` to `1212042`. --- updated-dependencies: - dependency-name: library/registry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: notifications triggered from CLI fails for repo functions (#19213) Signed-off-by: Jayendra Parsai <[email protected]> Co-authored-by: Jayendra Parsai <[email protected]> * feat: Support context switch for argocd-util (#19549) * feat: Support context switch for argocd-util Signed-off-by: Atsushi Neki <[email protected]> * execute codegen Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: Atsushi Neki <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: pasha-codefresh <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Co-authored-by: Atsushi Neki <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * fix appset-in-any-namespace issue with git generators (#19553) Signed-off-by: Ishita Sequeira <[email protected]> * chore: add e2e test for admin import & export (#19564) * docs: fix typo (#19567) Signed-off-by: Nolan Emirot <[email protected]> * chore(deps): bump bitnami/kubectl from 1.30 to 1.31 in /test/container (#19541) Bumps bitnami/kubectl from 1.30 to 1.31. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/prometheus/client_golang (#19544) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.19.1 to 1.20.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jann Fischer <[email protected]> * fix: 'argocd admin settings rbac can' - yaml loading problem(#19403) (#19575) fixes: #19403 Signed-off-by: Eugene Kim <[email protected]> * docs: Added SecurityGroup for groups TokenIDClaims (#19591) Signed-off-by: Joshua Ghali <[email protected]> * feat: add proxy to kustomize build operations (#18551) Signed-off-by: Nathanael Liechti <[email protected]> * feat: allow no_proxy to be specified on repoCreds (#18526) Signed-off-by: Nathanael Liechti <[email protected]> * ci: upload test results to codecov (#19476) * feat(ci): upload test results to codecov Signed-off-by: Michael Crenshaw <[email protected]> * only run on master Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> * chore(deps): bump github.com/prometheus/client_golang (#19609) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.0 to 1.20.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.1/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.20.0...v1.20.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: appset register rollout progressing status and correct parametersgenerated status to prevent update loop (#19613) * fix status and update loop Signed-off-by: Ilia Medvedev <[email protected]> * add tests Signed-off-by: Ilia Medvedev <[email protected]> * lint Signed-off-by: Ilia Medvedev <[email protected]> --------- Signed-off-by: Ilia Medvedev <[email protected]> * feat(dex): set logger based on argo config (#13191) (#19608) * feat(dex): set logger based on argo config Signed-off-by: Alexandre Gaudreault <[email protected]> * add env config Signed-off-by: Alexandre Gaudreault <[email protected]> * organize import bug? Signed-off-by: Alexandre Gaudreault <[email protected]> --------- Signed-off-by: Alexandre Gaudreault <[email protected]> * mark multiple sources feature as stable (#19594) Signed-off-by: Ishita Sequeira <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * fix dark mode logs fullscreen display not properly (#19505) Signed-off-by: Jessie Teng <[email protected]> Co-authored-by: Jessie Teng <[email protected]> * docs: fix stable message (#19334) * docs: fix stable message Signed-off-by: Junseokee <[email protected]> * docs: fix stable message Signed-off-by: Junseokee <[email protected]> --------- Signed-off-by: Junseokee <[email protected]> * improve filter component color contrast (#19468) Signed-off-by: Jessie Teng <[email protected]> Co-authored-by: Jessie Teng <[email protected]> * fix: cache helm-index in Redis cluster (#12314) (#19530) * fix: cache helm-index in Redis cluster Signed-off-by: JenTing Hsiao <[email protected]> * Update repository.go Fix order Signed-off-by: Dan Garfield <[email protected]> --------- Signed-off-by: JenTing Hsiao <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * fix: Floating title content incorrect for multi-sources (#17274) (#19623) Signed-off-by: Keith Chong <[email protected]> * doc: fix bullet rendering in config-management-plugin-v2.md (#19626) Bullets need to start with blank line, otherwise they don't render on read the docs. GitHub markdown doesn't require them but read the docs does Signed-off-by: Cornelius Roemer <[email protected]> * fix(appset): migrateStatus updates appset pointer after updating (#19619) # Context: `migrateStatus` updates the status of the appset but after succeeding it does not update the in memory object which means that that new updates may fail due to conflict since it's comparing it to the object previous to updating it in `migrateStatus`. # What does this PR? - After updating the appset object in `migrateStatus` it gets the object again to reference it in the appset pointer of the reconciler. Signed-off-by: Carlos Rejano <[email protected]> * fix(#16842): system level extensions not working properly (#19612) * use event to notify extensions changes Signed-off-by: Yiwei Gong <[email protected]> * use custom event target implementation Signed-off-by: Yiwei Gong <[email protected]> --------- Signed-off-by: Yiwei Gong <[email protected]> * chore(deps): bump library/golang in /test/container (#19540) Bumps library/golang from `a400dc7` to `8e529b6`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Cleanup some timing checkpoints (#19517) Adding same checkpoint in a loop would be misleading with multiple sources, also unmarshal checkpoint has a wrong name if there's a loop. Remove checkpoints in the loop and rename the unmarshal checkpoint. Signed-off-by: Andrii Korotkov <[email protected]> * fix(appset): informer is not a kubernetes informer (#18905) (#19618) Signed-off-by: Michael Crenshaw <[email protected]> * feat: Add EndpointSlice to resource icon (#19362) - Add EndpointSlice to resourceIcons map Signed-off-by: Mike <[email protected]> Co-authored-by: AS <[email protected]> * update the web based terminal docs (#19621) add fixes for the docs resolve minor fix Signed-off-by: nitishfy <[email protected]> * nit (#19639) Signed-off-by: Andrei Vishniakov <[email protected]> * fix: apps summary view health icon&name alignment (#19450) * fix apps summary view health icon&name alignment Signed-off-by: Jessie Teng <[email protected]> * fix unit tests Signed-off-by: Jessie Teng <[email protected]> --------- Signed-off-by: Jessie Teng <[email protected]> Co-authored-by: Jessie Teng <[email protected]> * chore: Clarify the meaning of secret exfiltration via ApplicationSet (issue #18560) (#19000) * Chore: Clarify the meaning of secret exfiltration via ApplicationSet in any namespace Signed-off-by: TheCoolDrop <[email protected]> Signed-off-by: Vanio Begic <[email protected]> * chore: Fix typo Signed-off-by: Vanio Begic <[email protected]> --------- Signed-off-by: TheCoolDrop <[email protected]> Signed-off-by: Vanio Begic <[email protected]> * feat: Implement cluster-api MachinePool CRD health checks (#19595) Signed-off-by: afarbos <[email protected]> --------- Signed-off-by: Arnaud Farbos <[email protected]> Signed-off-by: afarbos <[email protected]> * fix: set GOMAXPROCS automatically with uber-go/automaxprocs (#16528) Signed-off-by: Brightside56 <[email protected]> Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]> * chore(deps): bump github.com/google/btree from 1.1.2 to 1.1.3 (#19633) Bumps [github.com/google/btree](https://github.com/google/btree) from 1.1.2 to 1.1.3. - [Commits](https://github.com/google/btree/compare/v1.1.2...v1.1.3) --- updated-dependencies: - dependency-name: github.com/google/btree dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(tests): speed up unit tests (#19617) Signed-off-by: Michael Crenshaw <[email protected]> * fix(appset): remove cache references (#19647) Signed-off-by: rumstead <[email protected]> * chore: enable lint for deprecated symbols (#19651) Signed-off-by: Michael Crenshaw <[email protected]> * chore(deps): bump k8s libs from 0.29.6 to 0.30.4 (#19074) * chore(deps): bump k8s libs from 0.29.6 to 0.30.2 Signed-off-by: Michael Crenshaw <[email protected]> * latest commit Signed-off-by: Michael Crenshaw <[email protected]> * update known types Signed-off-by: Michael Crenshaw <[email protected]> * bump controller-runtime to a version that's compatible with go-client 0.30.x Signed-off-by: Michael Crenshaw <[email protected]> * update go-to-protobuf flag Signed-off-by: Michael Crenshaw <[email protected]> * handle new requirements for proto file locations Signed-off-by: Michael Crenshaw <[email protected]> * bump gitops-engine version Signed-off-by: Michael Crenshaw <[email protected]> * fix openapigen Signed-off-by: Michael Crenshaw <[email protected]> * remove toolchain Signed-off-by: Michael Crenshaw <[email protected]> * bump gitops-engine version Signed-off-by: Michael Crenshaw <[email protected]> * no need for replace now Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> * chore: bump k8s to 1.31 (#19654) * chore(deps): bump k8s libs from 0.29.6 to 0.30.2 Signed-off-by: Michael Crenshaw <[email protected]> * latest commit Signed-off-by: Michael Crenshaw <[email protected]> * update known types Signed-off-by: Michael Crenshaw <[email protected]> * bump controller-runtime to a version that's compatible with go-client 0.30.x Signed-off-by: Michael Crenshaw <[email protected]> * update go-to-protobuf flag Signed-off-by: Michael Crenshaw <[email protected]> * handle new requirements for proto file locations Signed-off-by: Michael Crenshaw <[email protected]> * bump gitops-engine version Signed-off-by: Michael Crenshaw <[email protected]> * fix openapigen Signed-off-by: Michael Crenshaw <[email protected]> * remove toolchain Signed-off-by: Michael Crenshaw <[email protected]> * bump gitops-engine version Signed-off-by: Michael Crenshaw <[email protected]> * chore: enable lint for deprecated symbols Signed-off-by: Michael Crenshaw <[email protected]> * chore: bump to k8s 1.31 Signed-off-by: Michael Crenshaw <[email protected]> * codegen Signed-off-by: Michael Crenshaw <[email protected]> * don't be generic if you don't have to be Signed-off-by: Michael Crenshaw <[email protected]> * don't be generic if you don't have to be Signed-off-by: Michael Crenshaw <[email protected]> * new commit Signed-off-by: Michael Crenshaw <[email protected]> * use gitops-engine commit Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> * chore(deps): bump go.opentelemetry.io/otel/sdk from 1.28.0 to 1.29.0 (#19673) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.28.0 to 1.29.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/open-telemetry/opentelemetry-go/compare/v1.28.0...v1.29.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump micromatch from 4.0.5 to 4.0.8 in /ui (#19672) Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/4.0.8/CHANGELOG.md) - [Commits](https://github.com/micromatch/micromatch/compare/4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(ui): extension can crash outside of error boundary (#19667) Signed-off-by: Remington Breeze <[email protected]> * test: skip flaky logs tests (#13398) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> * [Bot] docs: Update Snyk reports (#19679) Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]> * chore(deps): bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc (#19683) Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.53.0 to 0.54.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](https://github.com/open-telemetry/opentelemetry-go-contrib/compare/zpages/v0.53.0...zpages/v0.54.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/prometheus/client_golang (#19682) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.1 to 1.20.2. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.20.1...v1.20.2) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: note cluster scoping changes in 2.12x (#19684) * docs: note cluster scoping changes in 2.12x Related to #18748,#19585 and #19587. Signed-off-by: Blake Pettersson <[email protected]> * docs: add note in projects doc. Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]> * feat: introduce health checks for MonoVertexRollouts (#19688) Signed-off-by: Dillen Padhiar <[email protected]> * feat: Add applicationset metrics (#19691) * add appset metrics Signed-off-by: Ilia Medvedev <[email protected]> * cleanup Signed-off-by: Ilia Medvedev <[email protected]> * cleanup Signed-off-by: Ilia Medvedev <[email protected]> * address comments and fix test parallelism issue Signed-off-by: Ilia Medvedev <[email protected]> * fix controller unit tests - add metrics to tests Signed-off-by: Ilia Medvedev <[email protected]> * lint Signed-off-by: Ilia Medvedev <[email protected]> * lint Signed-off-by: Ilia Medvedev <[email protected]> * Add FakeAppsetMetrics to clear up registry and create metrics structure for tests without causing collisions Signed-off-by: Ilia Medvedev <[email protected]> * Change fake metrics implementation Signed-off-by: Ilia Medvedev <[email protected]> * Fix typo Signed-off-by: Ilia Medvedev <[email protected]> --------- Signed-off-by: Ilia Medvedev <[email protected]> Co-authored-by: pashakostohrys <[email protected]> * chore(deps): bump chromedriver from 127.0.3 to 128.0.0 in /ui-test (#19635) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 127.0.3 to 128.0.0. - [Commits](https://github.com/giggio/node-chromedriver/compare/127.0.3...128.0.0) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: Allow disabling TLS from notifications controller and reposerver (#19630) Signed-off-by: Matthew Wynn <[email protected]> * chore(deps-dev): bump @types/node from 22.3.0 to 22.5.1 in /ui-test (#19706) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.3.0 to 22.5.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/Masterminds/semver/v3 from 3.2.1 to 3.3.0 (#19705) Bumps [github.com/Masterminds/semver/v3](https://github.com/Masterminds/semver) from 3.2.1 to 3.3.0. - [Release notes](https://github.com/Masterminds/semver/releases) - [Changelog](https://github.com/Masterminds/semver/blob/master/CHANGELOG.md) - [Commits](https://github.com/Masterminds/semver/compare/v3.2.1...v3.3.0) --- updated-dependencies: - dependency-name: github.com/Masterminds/semver/v3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: remove unnecessary 'replace' in go.mod (#19668) Signed-off-by: Michael Crenshaw <[email protected]> * fix clipboard copy duration issue (#19662) Signed-off-by: Zhao, Olivia <[email protected]> * fix: 'argocd admin settings rbac can' command should honor server.rbac.log.enforce.enable param in argocd-cm (#19264) * feat: implement 'argocd admin appset generate' to troubeshoot appsets (#19518) * feat: implement 'argocd appset generate' to troubeshoot appsets Signed-off-by: Alexander Matyushentsev <[email protected]> * remove unnecessary ErrorLog field Signed-off-by: Alexander Matyushentsev <[email protected]> * apply reviewer suggestions Signed-off-by: Alexander Matyushentsev <[email protected]> --------- Signed-off-by: Alexander Matyushentsev <[email protected]> * fix background colore issue in dark theme (#19464) Signed-off-by: Shi, Stone <[email protected]> * fix: diffing should not fail if resource fail schema validation (#19714) Signed-off-by: Alexander Matyushentsev <[email protected]> * fix: ApplicationSet e2e TestSyncPolicyCreateUpdate&TestSyncPolicyCreateOnly test race condition bug #19577 (#19578) * fixed e2e TestSyncPolicyCreateUpdate&TestSyncPolicyCreateOnly bug Signed-off-by: Li. Sparks <[email protected]> * format Signed-off-by: Li. Sparks <[email protected]> * change the comment, explain why apps still exists Signed-off-by: Li. Sparks <[email protected]> --------- Signed-off-by: Li. Sparks <[email protected]> * feat(ui): add extension the top-bar action menu (#19620) * add topbar action menu ext Signed-off-by: AS <[email protected]> Co-authored-by: ashutosh16 <[email protected]> Co-authored-by: Anton Gilgur <[email protected]> * feat: reduce redis traffic caused by app resource tree updates in redis (#19722) Signed-off-by: Alexander Matyushentsev <[email protected]> * fix(ui): fix create app panel reappear after closed (#19717) Signed-off-by: henry.liu <[email protected]> * fix(ui): container state (#18928) Signed-off-by: ashutosh16 <[email protected]> Co-authored-by: ashutosh16 <[email protected]> * fix: open new tab for repo url (#19736) * open new tab for repo url Signed-off-by: Jessie Teng <[email protected]> * fix yarn lint issue Signed-off-by: Jessie Teng <[email protected]> --------- Signed-off-by: Jessie Teng <[email protected]> Co-authored-by: Jessie Teng <[email protected]> * fix: Refine resource option evaluation for `argocd app sync` command (#17397) (#19579) This update refactors the `IncludeResource` logic to improve accuracy in resource filtering. Also, it includes new test cases to ensure the correctness of the changes. Fixes: #17397 Changes: - Rewritten `IncludeResource` function for better logic flow. - Added unit tests to validate the new behavior. - Found that two existing test cases were incorrect and fixed them. A closer review of this part is needed. Signed-off-by: Eugene Kim <[email protected]> * chore(deps-dev): bump @types/node from 22.5.1 to 22.5.2 in /ui-test (#19749) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.1 to 22.5.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/busybox in /test/e2e/multiarch-container (#19752) Bumps library/busybox from `9ae97d3` to `8274294`. --- updated-dependencies: - dependency-name: library/busybox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/mattn/go-zglob from 0.0.4 to 0.0.6 (#19755) Bumps [github.com/mattn/go-zglob](https://github.com/mattn/go-zglob) from 0.0.4 to 0.0.6. - [Commits](https://github.com/mattn/go-zglob/compare/v0.0.4...v0.0.6) --- updated-dependencies: - dependency-name: github.com/mattn/go-zglob dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump chromedriver from 128.0.0 to 128.0.1 in /ui-test (#19748) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 128.0.0 to 128.0.1. - [Commits](https://github.com/giggio/node-chromedriver/compare/128.0.0...128.0.1) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/casbin/casbin/v2 from 2.98.0 to 2.99.0 (#19754) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.98.0 to 2.99.0. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](https://github.com/casbin/casbin/compare/v2.98.0...v2.99.0) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump webpack from 5.84.1 to 5.94.0 in /ui (#19713) Bumps [webpack](https://github.com/webpack/webpack) from 5.84.1 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](https://github.com/webpack/webpack/compare/v5.84.1...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from 22.3.0 to 22.7.0 (#19659) Bumps library/node from 22.3.0 to 22.7.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from 22.5.1 to 22.7.0 in /test/container (#19658) Bumps library/node from 22.5.1 to 22.7.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from 22.5.1 to 22.7.0 in /ui-test (#19656) Bumps library/node from 22.5.1 to 22.7.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/xanzy/go-gitlab from 0.107.0 to 0.108.0 (#19690) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.107.0 to 0.108.0. - [Release notes](https://github.com/xanzy/go-gitlab/releases) - [Changelog](https://github.com/xanzy/go-gitlab/blob/main/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.107.0...v0.108.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/Masterminds/sprig/v3 from 3.2.3 to 3.3.0 (#19737) Bumps [github.com/Masterminds/sprig/v3](https://github.com/Masterminds/sprig) from 3.2.3 to 3.3.0. - [Release notes](https://github.com/Masterminds/sprig/releases) - [Changelog](https://github.com/Masterminds/sprig/blob/master/CHANGELOG.md) - [Commits](https://github.com/Masterminds/sprig/compare/v3.2.3...v3.3.0) --- updated-dependencies: - dependency-name: github.com/Masterminds/sprig/v3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Bot] docs: Update Snyk reports (#19745) Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump bitnami/kubectl in /test/container (#19753) Bumps bitnami/kubectl from `44f99aa` to `96ef4d3`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * fix: pass the correct parameter for strict tls validation in applicationset controller (#19759) Signed-off-by: ignas-kaziukenas_css <[email protected]> Co-authored-by: ignas-kaziukenas_css <[email protected]> * feat(util/notification): add duration and timestamp constants from stdlib time package (#10706) * feat(util/notification): add duration and timestamp constants from stdlib time package Signed-off-by: George MacRorie <[email protected]> * chore(docs): add details on new time constants Signed-off-by: George MacRorie <[email protected]> * chore: run go mod tidy Signed-off-by: George MacRorie <[email protected]> * chore(util/notification): use require.NoError instead of require.Nil Signed-off-by: George MacRorie <[email protected]> * chore: go mod tidy Signed-off-by: George MacRorie <[email protected]> --------- Signed-off-by: George MacRorie <[email protected]> * fix(ui): Added field bottom for Username and Passsword (#19762) * auth-field Signed-off-by: Surajyadav <[email protected]> * lint-fix Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> * fix(ui): reload credential template list after refresh (#19764) Signed-off-by: henry.liu <[email protected]> * fix: Fix semver resolution (#19644) Signed-off-by: Pierre Lebrun <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * fix(ui): fix first line log timestamp (#19724) Signed-off-by: henry.liu <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * chore(deps): bump library/node from 22.7.0 to 22.8.0 (#19779) Bumps library/node from 22.7.0 to 22.8.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from 22.7.0 to 22.8.0 in /test/container (#19778) Bumps library/node from 22.7.0 to 22.8.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @types/node from 22.5.2 to 22.5.3 in /ui-test (#19777) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.2 to 22.5.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from 22.7.0 to 22.8.0 in /ui-test (#19775) Bumps library/node from 22.7.0 to 22.8.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/upload-artifact from 4.3.6 to 4.4.0 (#19751) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.6 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/834a144ee995460fba8ed112a2fc961b36a5ec5a...50769540e7f4bd5e21e526ee35c689e35e0d6874) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: update keycloak.md (#17684) * Update keycloak.md The documentation is excellent, but after following it, i'v experienced an issue 401, and the UI loop to login, to fix it i restarted the argocd-server pod then it' worked well. Signed-off-by: abdaziz <[email protected]> * Update keycloak.md update the requested changes from @wanghong230 Signed-off-by: abdaziz <[email protected]> * Update keycloak.md Signed-off-by: abdaziz <[email protected]> * Update keycloak.md good format. Signed-off-by: abdaziz <[email protected]> --------- Signed-off-by: abdaziz <[email protected]> * chore: add gcflags option when build in cli-local command (#19742) Signed-off-by: daengdaengLee <[email protected]> * chore(deps): bump peter-evans/create-pull-request from 6.1.0 to 7.0.0 (#19776) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.1.0 to 7.0.0. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](https://github.com/peter-evans/create-pull-request/compare/c5a7806660adbe173f04e3e038b0ccdcd758773c...4320041ed380b20e97d388d56a7fb4f9b8c20e79) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(lint): errors reported by golangci-lint: S1009: should omit nil check; printf: non-constant format string (#19773) Signed-off-by: Cheng Fang <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * Update pygments to 2.15.1 (#19782) Signed-off-by: todaywasawesome <[email protected]> * feat: Decoupling application sync using impersonation (#17403) * Implementation of app sync with impersonation support Signed-off-by: anandf <[email protected]> * negation test Signed-off-by: Mangaal <[email protected]> * Update doc comments to remove server name as its not supported. Co-authored-by: Ishita Sequeira <[email protected]> Signed-off-by: Anand Francis Joseph <[email protected]> * Update glob pattern check for matching destinations. Co-authored-by: Ishita Sequeira <[email protected]> Signed-off-by: Anand Francis Joseph <[email protected]> * Corrected the code comments for namespace field and destination matching logic Signed-off-by: anandf <[email protected]> * Added missing generated files Signed-off-by: anandf <[email protected]> * Fixed golint errors caused due to to gofumpt validations Signed-off-by: anandf <[email protected]> * Fix golint errors with unit test code Signed-off-by: anandf <[email protected]> * Updated the go import ordering with local packages at the end Signed-off-by: anandf <[email protected]> * Addressed review comments Signed-off-by: anandf <[email protected]> * Fixed ES lint error caused due to missing class Signed-off-by: anandf <[email protected]> * Updated the documentation to address the review comments Signed-off-by: anandf <[email protected]> * Simplified the sync code and improved logs and error handling Signed-off-by: anandf <[email protected]> * Fixed E2E tests to fail when no sa is configured Signed-off-by: anandf <[email protected]> * Updated help message generated for CLI commands Signed-off-by: anandf <[email protected]> * Fixed failing tests due to default service account not used for sync operation Signed-off-by: anandf <[email protected]> * Fixed the error message when sync fails due to no matching sa Signed-off-by: anandf <[email protected]> * Removed repeating logs and added impersonation fields to logger Signed-off-by: anandf <[email protected]> * Made changes in the proposal to match the behaviour when no matching sa is found Signed-off-by: Anand Francis Joseph <[email protected]> --------- Signed-off-by: anandf <[email protected]> Signed-off-by: Mangaal <[email protected]> Signed-off-by: Anand Francis Joseph <[email protected]> Signed-off-by: Anand Francis Joseph <[email protected]> Co-authored-by: Mangaal <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]> * Fix local guide for building and testing docs (#19785) Signed-off-by: todaywasawesome <[email protected]> * Add links to index page (#19786) Signed-off-by: todaywasawesome <[email protected]> * fix: issue 19395 change delete icon color in dark model (#19747) * fix-19395 change delete icon color in dark model Signed-off-by: Esther Shen <[email protected]> * fix-19395 revert formatting changes Signed-off-by: Esther Shen <[email protected]> * fix-19395 revert formatting changes Signed-off-by: Esther Shen <[email protected]> * fix-19395 revert formatting changes Signed-off-by: Esther Shen <[email protected]> --------- Signed-off-by: Esther Shen <[email protected]> * chore(deps): bump google.golang.org/grpc from 1.65.0 to 1.66.0 (#19719) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.65.0 to 1.66.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.65.0...v1.66.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixed go.mod to remove the replace construct added for gitops-engine (#19788) Signed-off-by: anandf <[email protected]> * fix(cli): `admin settings rbac can` has inconsistency among project resources (#17805) * fix admin can inconsistency among resources Signed-off-by: xiaopeng <[email protected]> * revise logic and fix lint Signed-off-by: xiaopeng <[email protected]> --------- Signed-off-by: xiaopeng <[email protected]> * fix(appset): allow for shorthand git refs in git generators #15427 (#19783) * fix(appset): allow for shorthand git refs in git generators Signed-off-by: rumstead <[email protected]> * Retrigger CI pipeline Signed-off-by: rumstead <[email protected]> * attempt to fix goimports Signed-off-by: rumstead <[email protected]> * attempt to fix goimports Signed-off-by: rumstead <[email protected]> * remove redundant test Signed-off-by: rumstead <[email protected]> --------- Signed-off-by: rumstead <[email protected]> * chore(deps-dev): bump @types/node from 22.5.3 to 22.5.4 in /ui-test (#19794) * feat: Add metric to expose Applications conditions (#19438) Closes #13096 Implement a new metric exposing Applications conditions. This is particularly useful for SRE teams to be able to setup alerts on issues that aren't displayed via "health_status" and "sync_status" in the metric "argocd_app_info". Signed-off-by: Foyer Unix <[email protected]> Co-authored-by: Foyer Unix <[email protected]> * chore(deps): bump library/golang in /test/container (#19793) Bumps library/golang from `613a108` to `1a6db32`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump bitnami/kubectl in /test/container (#19792) Bumps bitnami/kubectl from `96ef4d3` to `664bf2a`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/busybox in /test/e2e/multiarch-container (#19791) Bumps library/busybox from `8274294` to `34b191d`. --- updated-dependencies: - dependency-name: library/busybox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golang.org/x/term from 0.23.0 to 0.24.0 (#19789) Bumps [golang.org/x/term](https://github.com/golang/term) from 0.23.0 to 0.24.0. - [Commits](https://github.com/golang/term/compare/v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Delete button should be disabled when one source remains (#18804) * docs: proposal to introduce 'Prune/Delete=confirm' sync option value (#19520) * docs: proposal to introduce 'Prune/Delete=confirm' sync option value Signed-off-by: Alexander Matyushentsev <[email protected]> * add clarifications Signed-off-by: Alexander Matyushentsev <[email protected]> --------- Signed-off-by: Alexander Matyushentsev <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * docs: Add Mozilla to USERS.md (#19802) Signed-off-by: Dustin Lactin <[email protected]> * Fix broken link from overview, previous merge conflict (#19801) Signed-off-by: todaywasawesome <[email protected]> * chore(deps): bump golang.org/x/net from 0.28.0 to 0.29.0 (#19808) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.28.0 to 0.29.0. - [Commits](https://github.com/golang/net/compare/v0.28.0...v0.29.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 (#19790) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.22.0 to 0.23.0. - [Commits](https://github.com/golang/oauth2/compare/v0.22.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump peter-evans/create-pull-request from 7.0.0 to 7.0.1 (#19806) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.0 to 7.0.1. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](https://github.com/peter-evans/create-pull-request/compare/4320041ed380b20e97d388d56a7fb4f9b8c20e79...8867c4aba1b742c39f8d0ba35429c2dfa4b6cb20) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump tj-actions/changed-files from 44.5.7 to 45.0.1 (#19750) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 44.5.7 to 45.0.1. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](https://github.com/tj-actions/changed-files/compare/c65cd883420fd2eb864698a825fc4162dd94482c...e9772d140489982e0e3704fea5ee93d536f1e275) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from `8ec0232` to `bd00c03` (#19814) Bumps library/node from `8ec0232` to `bd00c03`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node in /test/container (#19813) Bumps library/node from `8ec0232` to `bd00c03`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump bitnami/kubectl in /test/container (#19812) Bumps bitnami/kubectl from `664bf2a` to `7779e58`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/golang in /test/container (#19811) Bumps library/golang from `1a6db32` to `80cf6f9`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/prometheus/client_golang (#19810) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.20.2...v1.20.3) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from `8ec0232` to `c6add15` in /ui-test (#19807) Bumps library/node from `8ec0232` to `c6add15`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: manifest-generate-paths with autosync causes an undesirable refresh sync (#19799) Signed-off-by: pashakostohrys <[email protected]> * fix(appset): Retry on conflict when updating status (#19663) * fix(appset): Retry on conflict when updating status # Context: When updating the status of the applicationset object it can happen that it fails due to a conflict since the resourceVersion has changed due to a different update. This makes the reconcile fails and we need to wait until the following reconcile loop until it updates the relevant status fields and hope that the update calls don't fail again due a conflict. It can even happen that it gets stuck constantly due to this erriors. A better approach I would say is retrying when there is a conflict error with the newest version of the object, so we make sure we update the object with the latest version always. This has been raised in issue #19535 that failing due to conflicts can make the reconcile not able to proceed. # What does this PR? - Wraps all the `Update().Status` calls inside a retry function that will retry when the update fails due a conflict. - Adds appset to fake client subresources, if not the client can not correctly determine the status subresource. Refer to: https://github.com/kubernetes-sigs/controller-runtime/issues/2386, and https://github.com/kubernetes-sigs/controller-runtime/issues/2362. Signed-off-by: Carlos Rejano <[email protected]> * fixup! fix(appset): Retry on conflict when updating status --------- Signed-off-by: Carlos Rejano <[email protected]> Signed-off-by: carlosrejano <[email protected]> Co-authored-by: Carlos Rejano <[email protected]> * always execute sync if at least for one revision we identify if it was changed or no (#19828) Signed-off-by: pashakostohrys <[email protected]> * [Bot] docs: Update Snyk reports (#19831) * feat: add a button to show parameter details (#12183) (#16871) * chore(deps): bump library/registry in /test/container (#19842) Bumps library/registry from `1212042` to `ac0192b`. --- updated-dependencies: - dependency-name: library/registry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from `c6add15` to `bd00c03` in /ui-test (#19844) Bumps library/node from `c6add15` to `bd00c03`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump go version to 1.22.7 (#19845) Signed-off-by: Gergely Fábián <[email protected]> * Missing close ``` in kustomize documentation (#19850) As per title: ``` is missing in the first object. Signed-off-by: Andrea Cervesato <[email protected]> * feat(cli): ignore tracking annotation on backup restore (#18960) Signed-off-by: Alexandre Gaudreault <[email protected]> * fix(ui): Container Selector in Pods doesn't work (#19856) Signed-off-by: Rafal Pelczar <[email protected]> * chore(deps-dev): bump typescript from 5.5.4 to 5.6.2 in /ui-test (#19857) Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.5.4 to 5.6.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](https://github.com/microsoft/TypeScript/compare/v5.5.4...v5.6.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump google.golang.org/grpc from 1.66.0 to 1.66.1 (#19860) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.66.0 to 1.66.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.66.0...v1.66.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: fix Helm --set-file example (#19864) Signed-off-by: Marios Andreopoulos <[email protected]> * feat: Send user groups to proxy extensions (#19855) * feat: Send user groups to proxy extensions Signed-off-by: Leonardo Luz Almeida <[email protected]> * address review comments Signed-off-by: Leonardo Luz Almeida <[email protected]> --------- Signed-off-by: Leonardo Luz Almeida <[email protected]> * feat(lua actions): add a flag to Include builtin actions with resource overrides (#19708) * feat: include prebuilt action with overrides Signed-off-by: ashutosh16 <[email protected]> Signed-off-by: ashutosh16 <[email protected]> Signed-off-by: Ashu <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]> * fix(deeplinks): do not evaluate template when condition is false (#19625) (#19868) Signed-off-by: Alexandre Gaudreault <[email protected]> * fix: proxy url arg for repocreds command. (#19805) * Add proxy url arg for repocreds command. Co-authored-by: Li Wang <[email protected]> Signed-off-by: Miao Haoda <[email protected]> * commit the results of clidocsgen Signed-off-by: Miao Haoda <[email protected]> --------- Signed-off-by: Miao Haoda <[email protected]> Co-authored-by: Li Wang <[email protected]> * chore(deps): bump github.com/xanzy/go-gitlab from 0.108.0 to 0.109.0 (#19839) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.108.0 to 0.109.0. - [Release notes](https://github.com/xanzy/go-gitlab/releases) - [Changelog](https://github.com/xanzy/go-gitlab/blob/main/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.108.0...v0.109.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Augury as part of argocd users (#19890) Signed-off-by: mmuzh <[email protected]> * chore(deps): bump go.opentelemetry.io/otel/sdk from 1.29.0 to 1.30.0 (#19878) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.29.0 to 1.30.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/open-telemetry/opentelemetry-go/compare/v1.29.0...v1.30.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: improve error logs (#10592) (#19743) Signed-off-by: KangManJoo <[email protected]> * feat: add `--source-position` flag to `argocd get app` command to show parameter changes for multi-source application (#19887) Signed-off-by: nitishfy <[email protected]> * docs: mention information about where to set the `ARGOCD_SYNC_WAVE_DELAY` environment variable (#19879) * Update sync-waves.md Signed-off-by: Nitish Kumar <[email protected]> * Update docs/user-guide/sync-waves.md Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Nitish Kumar <[email protected]> --------- Signed-off-by: Nitish Kumar <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * chore(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc (#19877) Bumps [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go) from 1.27.0 to 1.30.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/open-telemetry/opentelemetry-go/compare/v1.27.0...v1.30.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/golang in /test/container (#19841) Bumps library/golang from `80cf6f9` to `4a3c2bc`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/golang from 1.22.0 to 1.23.1 in /test/remote (#19840) Bumps library/golang from 1.22.0 to 1.23.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: Implement PodDisruptionBudget CRD health checks (#19826) Signed-off-by: Arnaud Farbos <[email protected]> * chore(deps): bump library/golang from 1.22.6 to 1.23.1 (#19838) Bumps library/golang from 1.22.6 to 1.23.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump express from 4.19.2 to 4.20.0 in /ui (#19883) Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](https://github.com/expressjs/express/compare/4.19.2...4.20.0) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: openkruise health check npe error #19545 (#19660) * test: add broken unit test data Signed-off-by: Jingchao <[email protected]> * fix: npe error in kruise ds health-check Signed-off-by: Jingchao <[email protected]> --------- Signed-off-by: Jingchao <[email protected]> * docs: Add Installation Warning and Kustomize Guide (#19874) * Update installation docs: Add warning for ClusterRoleBinding and custom namespace Signed-off-by: nueavv <[email protected]> * Add support for installing Argo CD in custom namespace using Kustomize Signed-off-by: nueavv <[email protected]> * remove clusterrolebinding name Signed-off-by: nueavv <[email protected]> --------- Signed-off-by: nueavv <[email protected]> * docs: Clarify AWS profile mounting locations for EKS cluster addition (#19853) Signed-off-by: nueavv <[email protected]> * docs(sync windows): rename Sunday-Saturday (#19885) (#19886) * fix(sync windows): rename Sunday-Saturday Sunday-Saturday is ambiguous. It could mean: - sunday and saturday ONLY - from sunday to saturday (=every day of the week) In order to disambiguate, we could change the label to one of the following: - Every Day of the Week - Sunday to Saturday - From Sunday to Saturday Signed-off-by: Thiago Perrotta <[email protected]> * Update ui/src/app/settings/components/project-sync-windows-edit/project-sync-windows-edit.tsx Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Thiago Perrotta <[email protected]> ----…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
In v0.15.0, there was a breaking change to the fake client. Now, callers setting up a fake client need to manually call WithStatusSubresource for objects that have a status subresource. For more info, see:
#2259
Feature Request:
Rather than force users to manually configure the fake client, could we use reflection to check if the "Status" field exists? since it's just fake code, this seems like it would be safe?
Alternative implementations:
Alternatively, we could use the ObjectWithStatusSubResource interface from https://github.com/kubernetes-sigs/apiserver-runtime/blob/33c90185692756252ad3e36c5a940167d0de8f41/pkg/builder/resource/types.go#L81, but i'm not sure how widespread that is
The text was updated successfully, but these errors were encountered: