Skip to content

✨Deprecate the duplicated kubebuilder:validation:XPreserveUnknownFields marker. #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2020
Merged

✨Deprecate the duplicated kubebuilder:validation:XPreserveUnknownFields marker. #422

merged 2 commits into from
Oct 14, 2020

Conversation

jiachengxu
Copy link
Contributor

Remove the duplicated kubebuilder:validation:XPreserveUnknownFields marker.
Fixes #380

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2020
@jiachengxu
Copy link
Contributor Author

/assign @droot

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 17, 2020
@jiachengxu
Copy link
Contributor Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 6, 2020
@jiachengxu jiachengxu mentioned this pull request Sep 22, 2020
Closed
@DirectXMan12
Copy link
Contributor

A quick survey says that this marker is actually still being used, so I'm going to tweak this to deprecate it for the moment then merge.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2020
@DirectXMan12 DirectXMan12 changed the title ✨Remove the duplicated kubebuilder:validation:XPreserveUnknownFields marker. ✨Deprecate the duplicated kubebuilder:validation:XPreserveUnknownFields marker. Oct 14, 2020
jiachengxu and others added 2 commits October 14, 2020 13:43
@jiachengxu @DirectXMan12
Deprecate validation:XPreserveUnknownFields marker
90f7678 
It's a duplicate of pruning:PreserveUnknownFields, so we should
eventually remove it, but it's seeing some use in the wild.

Some folks use it at type-level, so port the `pruning:` variant to
suppor that as well.
@DirectXMan12
Test for type-level preserve-unknown-fields
72b140e 
This adds a test for type-level `pruning:PreserveUnknownFields` to the
crd test.
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, jiachengxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6fa696d into kubernetes-sigs:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@droot droot Awaiting requested review from droot

Assignees

@DirectXMan12 DirectXMan12

@droot droot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

duplicate marker: XPreserveUnknownFields vs PreserveUnknownFields
5 participants
@jiachengxu @fejta-bot @DirectXMan12 @k8s-ci-robot @droot