Skip to content

Commit fb09c91

Browse files
rramkumar1robscott
andcommitted
UUpdate pkg/body-based-routing/README.md
Co-authored-by: Rob Scott <[email protected]>
1 parent db43b27 commit fb09c91

File tree

5 files changed

+11
-8
lines changed

5 files changed

+11
-8
lines changed

cmd/body-based-routing/health.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import (
2727
)
2828

2929
type healthServer struct {
30-
logger logr.Logger
30+
logger logr.Logger
3131
}
3232

3333
func (s *healthServer) Check(ctx context.Context, in *healthPb.HealthCheckRequest) (*healthPb.HealthCheckResponse, error) {

cmd/body-based-routing/main.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ var (
4040
"grpcHealthPort",
4141
9003,
4242
"The port used for gRPC liveness and readiness probes")
43-
43+
4444
setupLog = ctrl.Log.WithName("setup")
4545
)
4646

@@ -106,7 +106,7 @@ func run() error {
106106
func registerHealthServer(mgr manager.Manager, logger logr.Logger, port int) error {
107107
srv := grpc.NewServer()
108108
healthPb.RegisterHealthServer(srv, &healthServer{
109-
logger: logger,
109+
logger: logger,
110110
})
111111
if err := mgr.Add(
112112
runnable.NoLeaderElection(runnable.GRPCServer("health", srv, port))); err != nil {

pkg/body-based-routing/handlers/request.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,14 @@ import (
2020
"context"
2121
"fmt"
2222
"encoding/json"
23+
"fmt"
2324

2425
"sigs.k8s.io/controller-runtime/pkg/log"
2526
logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/logging"
2627
basepb "github.com/envoyproxy/go-control-plane/envoy/config/core/v3"
2728
eppb "github.com/envoyproxy/go-control-plane/envoy/service/ext_proc/v3"
29+
"sigs.k8s.io/controller-runtime/pkg/log"
30+
logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/logging"
2831
)
2932

3033
// HandleRequestBody handles request bodies.
@@ -48,7 +51,7 @@ func (s *Server) HandleRequestBody(ctx context.Context, body *eppb.HttpBody) (*e
4851

4952
modelStr, ok := modelVal.(string)
5053
if !ok {
51-
logger.V(logutil.DEFAULT).Error("Model parameter value is not a string")
54+
logger.V(logutil.DEFAULT).Info("Model parameter value is not a string")
5255
return &eppb.ProcessingResponse{
5356
Response: &eppb.ProcessingResponse_RequestBody{
5457
RequestBody: &eppb.BodyResponse{},

pkg/body-based-routing/handlers/server.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ func NewServer() *Server {
3434

3535
// Server implements the Envoy external processing server.
3636
// https://www.envoyproxy.io/docs/envoy/latest/api-v3/service/ext_proc/v3/external_processor.proto
37-
type Server struct {}
37+
type Server struct{}
3838

3939
func (s *Server) Process(srv extProcPb.ExternalProcessor_ProcessServer) error {
4040
ctx := srv.Context()
@@ -66,7 +66,7 @@ func (s *Server) Process(srv extProcPb.ExternalProcessor_ProcessServer) error {
6666
case *extProcPb.ProcessingRequest_RequestHeaders:
6767
resp, err = s.HandleRequestHeaders(req.GetRequestHeaders())
6868
case *extProcPb.ProcessingRequest_RequestBody:
69-
resp, err = s.HandleRequestBody(req.GetRequestBody())
69+
resp, err = s.HandleRequestBody(ctx, req.GetRequestBody())
7070
case *extProcPb.ProcessingRequest_ResponseHeaders:
7171
resp, err = s.HandleResponseHeaders(req.GetResponseHeaders())
7272
case *extProcPb.ProcessingRequest_ResponseBody:

pkg/body-based-routing/server/runserver.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ import (
3232
"google.golang.org/grpc"
3333
"google.golang.org/grpc/credentials"
3434
"sigs.k8s.io/controller-runtime/pkg/manager"
35-
"sigs.k8s.io/gateway-api-inference-extension/pkg/body-based-routing/handlers"
3635
"sigs.k8s.io/gateway-api-inference-extension/internal/runnable"
36+
"sigs.k8s.io/gateway-api-inference-extension/pkg/body-based-routing/handlers"
3737
)
3838

3939
// ExtProcServerRunner provides methods to manage an external process server.
@@ -43,7 +43,7 @@ type ExtProcServerRunner struct {
4343

4444
// Default values for CLI flags in main
4545
const (
46-
DefaultGrpcPort = 9002 // default for --grpcPort
46+
DefaultGrpcPort = 9002 // default for --grpcPort
4747
)
4848

4949
func NewDefaultExtProcServerRunner() *ExtProcServerRunner {

0 commit comments

Comments
 (0)