Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Flexability in InferencePool Assignment #252

Open
danehans opened this issue Jan 29, 2025 · 2 comments
Open

Provide Flexability in InferencePool Assignment #252

danehans opened this issue Jan 29, 2025 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@danehans
Copy link
Contributor

Currently, EPP will only reconcile an InferencePool that matches its configured poolName CLI flag. A more flexible approach should be considered since changing InferencePools requires a restart. One approach to consider is using labels, where EPP can use a predicate to filter reconciling all InferencePools in its namespace to only one that matches its configured poolLabel matcher. EPP can follow Gateway API guidelines for conflict resolution.

@danehans
Copy link
Contributor Author

danehans commented Feb 3, 2025

@ahg-g @kfswain @robscott PTAL and provide your thoughts when you have a moment.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 3, 2025

I am supportive, would you like to make a concrete proposal? We need to resolve a few things:

  1. If we are going with a label, define a label key
  2. How to ensure that this aligns with the configuration api that defines a service reference? Should the EPP look at that instead? or spec that the EPP service reference and the label must be aligned, and if not the behavior is unknown?
  3. Since our current implementation of EPP assumes a single inferencePool, we need to also define a predictable behavior as to what exact pool the EPP will serve until we decide whether or not we want EPP to support multiple pools.

@kfswain kfswain added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants