Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EndpointSlice dependency #256

Closed
Tracked by #73
ahg-g opened this issue Jan 29, 2025 · 6 comments · Fixed by #271
Closed
Tracked by #73

Remove EndpointSlice dependency #256

ahg-g opened this issue Jan 29, 2025 · 6 comments · Fixed by #271
Assignees
Milestone

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Jan 29, 2025

The InferencePool API specs a pod selector for the endpoints, but the EPP implementation ignores that and uses a flag to a service ref.

Now that we landed on the pod selector approach after the API review, we need to switch to use the selector. This means:

  • Removing the EndpointSlice reconciler
  • Use InferencePool.Selector to list the pods and populate the datastore on every probe.
@danehans danehans added this to the v0.1.0-rc.1 milestone Jan 30, 2025
@danehans
Copy link
Contributor

Dupe of #158

@danehans
Copy link
Contributor

xref #252 to provide flexibility in InferencePool assignment.

@ahg-g
Copy link
Contributor Author

ahg-g commented Jan 30, 2025

Dupe of #158

This is more about removing the reconciler not just the flag.

@ahg-g
Copy link
Contributor Author

ahg-g commented Jan 30, 2025

/assign @kfswain

@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 11, 2025

/reopen

@k8s-ci-robot
Copy link
Contributor

@ahg-g: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 11, 2025
@ahg-g ahg-g closed this as completed Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants