Skip to content

Add license headers to all files #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #362
ahg-g opened this issue Feb 4, 2025 · 5 comments · Fixed by #370
Closed
Tracked by #362

Add license headers to all files #281

ahg-g opened this issue Feb 4, 2025 · 5 comments · Fixed by #370
Assignees

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Feb 4, 2025

No description provided.

@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 19, 2025

/label good-first-issue

@k8s-ci-robot
Copy link
Contributor

@ahg-g: The label(s) /label good-first-issue cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nirrozenbaum
Copy link
Contributor

/assign

@nirrozenbaum
Copy link
Contributor

@ahg-g I pushed a PR to fix this issue.

if that's fine with you, I'd like to create another (related) issue to add a script that checks whether all .go files have a license header. Then this script can be used in PRs gating automation to make sure no new files are introduced into the repo without the license header.

@nirrozenbaum
Copy link
Contributor

or alternatively another way to check that in PRs (not using script)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants