Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract between Envoy Extproc and EPP is incorrect. #298

Closed
Tracked by #362
ahmed-laiq opened this issue Feb 6, 2025 · 3 comments · Fixed by #377
Closed
Tracked by #362

Contract between Envoy Extproc and EPP is incorrect. #298

ahmed-laiq opened this issue Feb 6, 2025 · 3 comments · Fixed by #377
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ahmed-laiq
Copy link

What happened:
Envoy expects that the first field in the metadata should match the receiving namespace of the envoy extproc configuration. The data should be wrapped within the struct of this namespace key.

What you expected to happen:
The struct containing the key value for "IP:PORT" should be contained in the namespace key.

@ahmed-laiq ahmed-laiq added the kind/bug Categorizes issue or PR as related to a bug. label Feb 6, 2025
@kfswain
Copy link
Collaborator

kfswain commented Feb 6, 2025

/assign kfswain

@ahg-g
Copy link
Contributor

ahg-g commented Feb 7, 2025

we could have this as a flag and default it to something that aligns with the key name that we selected previously, one suggestion is gateway-destination-endpoint.dynamic_forwarding.selected_endpoints

@ahg-g
Copy link
Contributor

ahg-g commented Feb 18, 2025

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
3 participants