Defining an outer metadata struct as part of the extproc endpoint picking protocol #377
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/assign @AndresGuedez @robscott @kfswain @LiorLieberman |
|
@ahg-g: GitHub didn't allow me to assign the following users: AndresGuedez. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cmd/epp/main.go
Outdated
| "Header key used by Envoy to route to the appropriate pod. This must match Envoy configuration.") | ||
| "Header and response metadata key used by Envoy to route to the appropriate pod. This must match Envoy configuration.") | ||
| targetEndpointOuterMetadataKey = flag.String( | ||
| "TargetEndpointOuterMetadataKey", |
There was a problem hiding this comment.
It represents the receiving namespace of envoy, i think the name is a little confusing
There was a problem hiding this comment.
one suggestion from @LiorLieberman is to use destinationEndpointHintMetadataNamesapce as the key name, and change the targetEndpointKey to destinationEndpointHintKey to match with that.
Update the protocol doc based on the suggested edits Co-authored-by: Lior Lieberman <[email protected]>
| "x-gateway-destination-endpoint": <ip:port>" | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think I missed "```" here
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, AndresGuedez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Fixes #298
/hold