Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange directory structure of the repo #348

Closed
Tracked by #362
ahg-g opened this issue Feb 16, 2025 · 5 comments · Fixed by #372
Closed
Tracked by #362

Rearrange directory structure of the repo #348

ahg-g opened this issue Feb 16, 2025 · 5 comments · Fixed by #372
Assignees

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Feb 16, 2025

  1. Move pkg/manifests to site-src/manifests
  2. Rename pkg/ext-proc to pkg/epp
  3. Move pkg/epp/main.go to cmd/epp/main.go

This is more aligned with best practices for go repo structure, and allows us to host other apps, like the bod-to-header translation one: https://kubernetes.slack.com/archives/C071WA7R9LY/p1739569116457569

@danehans @kfswain wdyt?

@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 16, 2025

The renaming of ext-proc to epp can be as a followup, not necessarily now just so we don't cause too much conflict with ongoing PRs.

@tchap
Copy link
Contributor

tchap commented Feb 19, 2025

If you don't mind,

/assign

@tchap
Copy link
Contributor

tchap commented Feb 19, 2025

I am not entirely sure why manifests should be in site-src. What is the reasoning there? But no hard feelings really. Not sure what a better place would be. config?

@kfswain
Copy link
Collaborator

kfswain commented Feb 19, 2025

I think the idea was that the manifests are used in the getting started guide. But I agree that it might be odd to have them show up on the site at their own path.

config does make sense to me
Otherwise the rest of this SGTM

@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 19, 2025

yeah, config makes sense too, the main thing was to move out of pkg/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants