Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/ext-proc -> cmd/ext-proc #368

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Move pkg/ext-proc -> cmd/ext-proc #368

merged 2 commits into from
Feb 19, 2025

Conversation

tchap
Copy link
Contributor

@tchap tchap commented Feb 19, 2025

Related to #348 .

I also took liberty to improve Dockerfile to cache dependencies and not upload 80 MB of data into Docker.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @tchap. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7d712d0
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67b5f22903559300084bda3d
😎 Deploy Preview https://deploy-preview-368--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 19, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2025
tchap added 2 commits February 19, 2025 16:00
@tchap
Move pkg/ext-proc -> cmd/ext-proc
57e3ec2
@tchap
Rework Dockerfile
7d712d0 
- Cache dependencies
- Upload only the files needed
@tchap tchap force-pushed the rework-directory-structure branch from fe0dcc0 to 7d712d0 Compare February 19, 2025 15:00
ahg-g
ahg-g reviewed Feb 19, 2025
View reviewed changes
Dockerfile
COPY pkg ./pkg
COPY internal ./internal
COPY api ./api
WORKDIR /src/cmd/ext-proc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how should we organize the dockerfiles if we want to support multiple applications in the repo? say we add another app under cmd/ for #355?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you create a separate Dockerfile for each, unless you need all of them in a single image, which you usually don't. But even that is perfectly possible by using a build stage per executable, then copying all the artifacts into the last stage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we create a docker file per app, how do you suggest we do it? Using different names at the top level or put the dockerfile in the cmd/app directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually create docker/<component>.Dockerfile, e.g. docker/ExtProc.Dockerfile. But that is simply what I came up with for my projects.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 19, 2025

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit cab2472 into kubernetes-sigs:main Feb 19, 2025
8 checks passed
@tchap tchap deleted the rework-directory-structure branch February 19, 2025 15:21
@ahg-g ahg-g mentioned this pull request Feb 19, 2025
Closed
rramkumar1 pushed a commit to rramkumar1/gateway-api-inference-extension that referenced this pull request Mar 3, 2025
@tchap @rramkumar1
Move pkg/ext-proc -> cmd/ext-proc (kubernetes-sigs#368)
52606c2 
* Move pkg/ext-proc -> cmd/ext-proc

* Rework Dockerfile

- Cache dependencies
- Upload only the files needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@danehans danehans Awaiting requested review from danehans

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tchap @k8s-ci-robot @ahg-g