Rename TargetPortNumber to PortNumber in ExtensionRef

[ahg-g]

In ExtensionReference in the InferencePool we name the port number TargetPortNumber, this is misleading since it should be the port number on the Service fronting the epp pods, not the port number on the epp pods themselves.

[hzxuzhonghu]

There is a targetPortNumber in Spec https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/api/v1alpha1/inferencepool_types.go#L61

I may need to read more about the code to understand the diff

BTW what is EPP abbrev for, it was ext-proc

[ahg-g]

There is a targetPortNumber in Spec https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/api/v1alpha1/inferencepool_types.go#L61

This is the targetPortNumber on the model servers.

This issue is referring to the port number of the epp (ext-proc) pods that the proxy will use to communicate with via the ext-proc protocol.

BTW what is EPP abbrev for, it was ext-proc

EPP is an abbreviation of "endpoint picker".

[hzxuzhonghu]

got it, i am not sure what is ExtensionReference for? Seems we donot care about it at all. It is just set to envoy ext-proc filter(by patch) rather than used by epp

[ahg-g]

It is for the gateway controller that sets up the extension with the proxy. It needs to know where the extension is running to configure the proxy with the extension.

[hzxuzhonghu]

/assign

[ahg-g]

Thanks @hzxuzhonghu for working on this, note that this requires changing the api to v1alpha2; we can do that by simply renaming v1alpha1 to v1alpha2 since k8s deprecation policy allows deprecating an alpha API in the same release: https://kubernetes.io/docs/reference/using-api/deprecation-policy/

[hzxuzhonghu]

Are there anyother fields that need to be deprecated or mutated, i can change at the sametime

[ahg-g]

Yes: #379 and potentially #385

[ahg-g]

btw, I see @kfswain assigned #379 to himself

[kfswain]

If you'd like to take #379 , feel free!

[hzxuzhonghu]

Ok, let me try to file a pr next monday