-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added v1alpha2 api #398
Added v1alpha2 api #398
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks, are you planning to follow up with a PR to remove v1alpha1? /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
The API updates LGTM. |
/hold cancel |
I didnot realize it is to be removed, i can do that |
* copy api v1alpha1 to v1alpha2 * Add nested status * auto generate * use v1alpha2
two changes:
Rename TargetPortNumber to PortNumber in ExtensionRef Rename TargetPortNumber to PortNumber in ExtensionRef #376
InferencePool nested status InferencePool should have nested status #379
This is not guranteeing compatibilty, because no conversion between v1alpha1 and v1alpha2 supported