Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added v1alpha2 api #398

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Added v1alpha2 api #398

merged 4 commits into from
Feb 24, 2025

Conversation

hzxuzhonghu
Copy link
Member

@hzxuzhonghu hzxuzhonghu commented Feb 24, 2025

two changes:

  1. Rename TargetPortNumber to PortNumber in ExtensionRef Rename TargetPortNumber to PortNumber in ExtensionRef #376

  2. InferencePool nested status InferencePool should have nested status #379

This is not guranteeing compatibilty, because no conversion between v1alpha1 and v1alpha2 supported

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2025
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 0dcd92f
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67bc571b387c660008abb839
😎 Deploy Preview https://deploy-preview-398--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 24, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Feb 24, 2025

Thanks, are you planning to follow up with a PR to remove v1alpha1?

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Feb 24, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
@kfswain
Copy link
Collaborator

kfswain commented Feb 24, 2025

The API updates LGTM.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 24, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 58335c0 into kubernetes-sigs:main Feb 24, 2025
8 checks passed
@hzxuzhonghu
Copy link
Member Author

Thanks, are you planning to follow up with a PR to remove v1alpha1?

I didnot realize it is to be removed, i can do that

kaushikmitr pushed a commit to kaushikmitr/llm-instance-gateway that referenced this pull request Feb 27, 2025
* copy api v1alpha1 to v1alpha2

* Add nested status

* auto generate

* use v1alpha2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants