Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ModelName immutable #408

Closed
Tracked by #362
ahg-g opened this issue Feb 26, 2025 · 2 comments · Fixed by #427
Closed
Tracked by #362

Make ModelName immutable #408

ahg-g opened this issue Feb 26, 2025 · 2 comments · Fixed by #427
Assignees

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Feb 26, 2025

What would you like to be added:

Make ModelName in InferenceModel immutable.

While we can't do this using CEL, we can add ValidatingAdmissionPolicy as part of the CRD installation.

Why is this needed:

ModelName for a specific InferenceModel should not change. We had to add ModelName as a separate parameter instead of using the object name because the model name can be arbitrary and more flexible than k8s object names.

@hzxuzhonghu
Copy link
Member

@hzxuzhonghu
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants